fix: exclude system volumes from a clone container

agneum · agneum · commit a0b56e7592ec · 2021-03-26T10:59:00.000+07:00
diff --git a/pkg/services/provision/docker/docker.go b/pkg/services/provision/docker/docker.go
@@ -26,6 +26,8 @@ const (
 	labelClone = "dblab_clone"
 )
 
+var systemVolumes = []string{"/sys", "/lib", "/proc"}
+
 // RunContainer runs specified container.
 func RunContainer(r runners.Runner, c *resources.AppConfig) (string, error) {
 	hostInfo, err := host.Info()
@@ -94,6 +96,11 @@ func buildMountVolumes(r runners.Runner, c *resources.AppConfig, containerID str
 	volumes := make([]string, 0, len(mounts))
 
 	for _, mountPoint := range mountPoints {
+		// Exclude system volumes from a clone container.
+		if isSystemVolume(mountPoint.Source) {
+			continue
+		}
+
 		// Add extra mount for socket directories.
 		if strings.HasPrefix(unixSocketCloneDir, mountPoint.Destination) {
 			volumes = append(volumes, buildSocketMount(unixSocketCloneDir, mountPoint.Source, mountPoint.Destination))
@@ -114,6 +121,16 @@ func buildMountVolumes(r runners.Runner, c *resources.AppConfig, containerID str
 	return volumes, nil
 }
 
+func isSystemVolume(source string) bool {
+	for _, sysVolume := range systemVolumes {
+		if strings.HasPrefix(source, sysVolume) {
+			return true
+		}
+	}
+
+	return false
+}
+
 // buildSocketMount builds a socket directory mounting rely on dataDir mounting.
 func buildSocketMount(socketDir, hostDataDir, destinationDir string) string {
 	socketPath := strings.TrimPrefix(socketDir, destinationDir)
