Merge branch 'v2.0' into 'master'

agneum · agneum · commit f55e0655eb4a · 2020-11-10T12:05:22.000Z
feat: skip creation of the snapshot on start (#187) See merge request postgres-ai/database-lab!199
diff --git a/configs/config.example.physical_generic.yml b/configs/config.example.physical_generic.yml
@@ -167,6 +167,9 @@ retrieval:
 
     physicalSnapshot:
       options:
+        # Skip taking a snapshot while the retrieval starts.
+        skipStartSnapshot: false
+
         # Promote PGDATA after data fetching.
         promotion:
           # Enable PGDATA promotion.
diff --git a/configs/config.example.physical_walg.yml b/configs/config.example.physical_walg.yml
@@ -153,6 +153,9 @@ retrieval:
 
     physicalSnapshot:
       options:
+        # Skip taking a snapshot while the retrieval starts.
+        skipStartSnapshot: false
+
         # Promote PGDATA after data fetching.
         promotion:
           # Enable PGDATA promotion.
diff --git a/pkg/retrieval/engine/postgres/snapshot/physical.go b/pkg/retrieval/engine/postgres/snapshot/physical.go
@@ -82,6 +82,7 @@ type PhysicalInitial struct {
 
 // PhysicalOptions describes options for a physical initialization job.
 type PhysicalOptions struct {
+	SkipStartSnapshot   bool              `yaml:"skipStartSnapshot"`
 	Promotion           Promotion         `yaml:"promotion"`
 	PreprocessingScript string            `yaml:"preprocessingScript"`
 	Configs             map[string]string `yaml:"configs"`
@@ -203,6 +204,12 @@ func (p *PhysicalInitial) Run(ctx context.Context) (err error) {
 	default:
 	}
 
+	if p.options.SkipStartSnapshot {
+		log.Msg("Skip taking a snapshot at the start")
+
+		return nil
+	}
+
 	p.dbMark.DataStateAt = extractDataStateAt(p.dbMarker)
 
 	// Snapshot data.
