Skip to content

Bugfix/issue 38 #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 11, 2021
Merged

Bugfix/issue 38 #39

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c817894
Issue #38: fix backand crash on nonhashable row insert.
Feb 4, 2021
2a38b71
Issue #38: remove useless comment.
Feb 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions expected/pg_variables_trans.out
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3829,3 +3829,8 @@ SELECT pgv_free();

(1 row)

--
-- Test case for issue #38 [PGPRO-4676]
--
SELECT pgv_insert('test', 'x5', ROW ((2::int, 1::int)), TRUE);
ERROR: could not identify a hash function for type record
7 changes: 7 additions & 0 deletions pg_variables.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2116,6 +2116,13 @@ rollbackSavepoint(TransObject *object, TransObjectType type)
{
TransState *state;

/* Nothing to do here if trans object was removed already. */
if (dlist_is_empty(&object->states))
{
removeObject(object, type);
return;
}

state = GetActualState(object);
removeState(object, type, state);

Expand Down
6 changes: 6 additions & 0 deletions sql/pg_variables_trans.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1163,3 +1163,9 @@ SELECT pgv_insert('vars', 'r2', tab) FROM tab;
SELECT pgv_select('vars', 'r2');

SELECT pgv_free();


--
-- Test case for issue #38 [PGPRO-4676]
--
SELECT pgv_insert('test', 'x5', ROW ((2::int, 1::int)), TRUE);