Fix header inclusion order in xloginsert.c with lz4.h

michaelpq · michaelpq · commit 0071fc71277e · 2022-03-11T10:59:47.000+09:00
Per project policy, all system and library headers need to be declared in the backend code after "postgres.h" and before the internal headers, but 4035cd5 broke this policy when adding support for LZ4 in wal_compression. Noticed while reviewing the patch to add support for zstd in this area. This only impacts HEAD, so there is no need for a back-patch.
diff --git a/src/backend/access/transam/xloginsert.c b/src/backend/access/transam/xloginsert.c
@@ -19,6 +19,10 @@
 
 #include "postgres.h"
 
+#ifdef USE_LZ4
+#include <lz4.h>
+#endif
+
 #include "access/xact.h"
 #include "access/xlog.h"
 #include "access/xlog_internal.h"
@@ -38,7 +42,6 @@
  * backup block image.
  */
 #ifdef USE_LZ4
-#include <lz4.h>
 #define	LZ4_MAX_BLCKSZ		LZ4_COMPRESSBOUND(BLCKSZ)
 #else
 #define LZ4_MAX_BLCKSZ		0
