Fix pg_basebackup so that it accepts 0 as a valid compression level.

MasaoFujii · MasaoFujii · commit 013f423729a8 · 2016-08-01T17:37:53.000+09:00
The help message for pg_basebackup specifies that the numbers 0 through 9
are accepted as valid values of -Z option. But, previously -Z 0 was rejected
as an invalid compression level.

Per discussion, it's better to make pg_basebackup treat 0 as valid
compression level meaning no compression, like pg_dump.

Back-patch to all supported versions.

Reported-By: Jeff Janes
Reviewed-By: Amit Kapila
Discussion: CAMkU=1x+GwjSayc57v6w87ij6iRGFWt=hVfM0B64b1_bPVKRqg@mail.gmail.com
diff --git a/doc/src/sgml/ref/pg_basebackup.sgml b/doc/src/sgml/ref/pg_basebackup.sgml
@@ -283,7 +283,7 @@ PostgreSQL documentation
       <listitem>
        <para>
         Enables gzip compression of tar file output, and specifies the
-        compression level (1 through 9, 9 being best
+        compression level (0 through 9, 0 being no compression and 9 being best
         compression). Compression is only available when using the tar
         format.
        </para>
diff --git a/src/bin/pg_basebackup/pg_basebackup.c b/src/bin/pg_basebackup/pg_basebackup.c
@@ -1789,7 +1789,7 @@ main(int argc, char **argv)
 				break;
 			case 'Z':
 				compresslevel = atoi(optarg);
-				if (compresslevel <= 0 || compresslevel > 9)
+				if (compresslevel < 0 || compresslevel > 9)
 				{
 					fprintf(stderr, _("%s: invalid compression level \"%s\"\n"),
 							progname, optarg);

Original file line number	Diff line number	Diff line change
`@@ -1789,7 +1789,7 @@ main(int argc, char **argv)`
`1789`	`1789`	`break;`
`1790`	`1790`	`case 'Z':`
`1791`	`1791`	`compresslevel = atoi(optarg);`
`1792`		`- if (compresslevel <= 0 \|\| compresslevel > 9)`
	`1792`	`+ if (compresslevel < 0 \|\| compresslevel > 9)`
`1793`	`1793`	`{`
`1794`	`1794`	`fprintf(stderr, _("%s: invalid compression level \"%s\"\n"),`
`1795`	`1795`	`progname, optarg);`