Avoiding

vadim4o · vadim4o · commit 02ba3cf871f3 · 1996-12-14T05:20:39.000Z
cc1: warnings being treated as errors
transsup.c: In function `TransBlockGetLastTransactionIdStatus':
transsup.c:122: warning: unsigned value &gt;= 0 is always 1
gmake[3]: *** [transsup.o] Error 1
...
diff --git a/src/backend/access/transam/transsup.c b/src/backend/access/transam/transsup.c
@@ -7,7 +7,7 @@
  *
  *
  * IDENTIFICATION
- *    $Header: /cvsroot/pgsql/src/backend/access/transam/Attic/transsup.c,v 1.6 1996/11/05 11:12:30 scrappy Exp $
+ *    $Header: /cvsroot/pgsql/src/backend/access/transam/Attic/transsup.c,v 1.7 1996/12/14 05:20:39 vadim Exp $
  *
  * NOTES
  *    This file contains support functions for the high
@@ -119,8 +119,8 @@ TransBlockGetLastTransactionIdStatus(Block tblock,
      * ----------------
      */
     maxIndex = TP_NumXidStatusPerBlock;
-    for (index = maxIndex-1; index>=0; index--) {
-	offset =  BitIndexOf(index);
+    for (index = maxIndex; index > 0; index--) {
+	offset =  BitIndexOf(index-1);
 	bit1 =    ((bits8) BitArrayBitIsSet((BitArray) tblock, offset++)) << 1;
 	bit2 =    (bits8)  BitArrayBitIsSet((BitArray) tblock, offset);
 	
@@ -135,7 +135,7 @@ TransBlockGetLastTransactionIdStatus(Block tblock,
 	if (xstatus != XID_INPROGRESS) {
 	    if (returnXidP != NULL) {
 		TransactionIdStore(baseXid, returnXidP);
-		TransactionIdAdd(returnXidP, index);
+		TransactionIdAdd(returnXidP, index - 1);
 	    }
 	    break;
 	}

Original file line number	Diff line number	Diff line change
`@@ -7,7 +7,7 @@`
`7`	`7`	`*`
`8`	`8`	`*`
`9`	`9`	`* IDENTIFICATION`
`10`		`- * $Header: /cvsroot/pgsql/src/backend/access/transam/Attic/transsup.c,v 1.6 1996/11/05 11:12:30 scrappy Exp $`
	`10`	`+ * $Header: /cvsroot/pgsql/src/backend/access/transam/Attic/transsup.c,v 1.7 1996/12/14 05:20:39 vadim Exp $`
`11`	`11`	`*`
`12`	`12`	`* NOTES`
`13`	`13`	`* This file contains support functions for the high`
`@@ -119,8 +119,8 @@ TransBlockGetLastTransactionIdStatus(Block tblock,`
`119`	`119`	`* ----------------`
`120`	`120`	`*/`
`121`	`121`	`maxIndex = TP_NumXidStatusPerBlock;`
`122`		`- for (index = maxIndex-1; index>=0; index--) {`
`123`		`- offset = BitIndexOf(index);`
	`122`	`+ for (index = maxIndex; index > 0; index--) {`
	`123`	`+ offset = BitIndexOf(index-1);`
`124`	`124`	`bit1 = ((bits8) BitArrayBitIsSet((BitArray) tblock, offset++)) << 1;`
`125`	`125`	`bit2 = (bits8) BitArrayBitIsSet((BitArray) tblock, offset);`
`126`	`126`
`@@ -135,7 +135,7 @@ TransBlockGetLastTransactionIdStatus(Block tblock,`
`135`	`135`	`if (xstatus != XID_INPROGRESS) {`
`136`	`136`	`if (returnXidP != NULL) {`
`137`	`137`	`TransactionIdStore(baseXid, returnXidP);`
`138`		`- TransactionIdAdd(returnXidP, index);`
	`138`	`+ TransactionIdAdd(returnXidP, index - 1);`
`139`	`139`	`}`
`140`	`140`	`break;`
`141`	`141`	`}`