pg_restore: Provide file name with one failure message

alvherre · alvherre · commit 0507c07b5d5e · 2020-05-08T19:38:46.000-04:00
Almost all error messages already include file name where relevant, but this one had been overlooked. Repair. Backpatch to 9.5. Author: Euler Taveira <euler.taveira@2ndquadrant.com> Discussion: https://postgr.es/m/CAH503wA_VOrcKL_43p9atRejCDYmOZ8MzfK9S6TJrQqBqNeAXA@mail.gmail.com Reviewed-by: Álvaro Herrera <alvherre@alvh.no-ip.org>
diff --git a/src/bin/pg_dump/pg_backup_directory.c b/src/bin/pg_dump/pg_backup_directory.c
@@ -400,7 +400,7 @@ _PrintFileData(ArchiveHandle *AH, char *filename)
 
 	free(buf);
 	if (cfclose(cfp) !=0)
-		fatal("could not close data file: %m");
+		fatal("could not close data file \"%s\": %m", filename);
 }
 
 /*

Original file line number	Diff line number	Diff line change
`@@ -400,7 +400,7 @@ _PrintFileData(ArchiveHandle AH, char filename)`
`400`	`400`
`401`	`401`	`free(buf);`
`402`	`402`	`if (cfclose(cfp) !=0)`
`403`		`- fatal("could not close data file: %m");`
	`403`	`+ fatal("could not close data file \"%s\": %m", filename);`
`404`	`404`	`}`
`405`	`405`
`406`	`406`	`/*`