typeTypeName() must return a pstrdup'd copy of the type name, not a

tglsfdc · tglsfdc · commit 05cd91a5825f · 2000-06-06T16:50:37.000Z
direct pointer into the syscache entry for the type.  In some cases
the syscache entry might get flushed before we are done using the
returned type name.  This bug accounts for difficult-to-repeat
failures seen when INSERTs into columns of certain data types are
run in parallel with VACUUMs of system tables.  There may be related
problems elsewhere --- we need to take a harder look at uses of
syscache data.
diff --git a/src/backend/parser/parse_type.c b/src/backend/parser/parse_type.c
@@ -8,7 +8,7 @@
  *
  *
  * IDENTIFICATION
- *	  $Header: /cvsroot/pgsql/src/backend/parser/parse_type.c,v 1.30 2000/05/30 04:24:49 tgl Exp $
+ *	  $Header: /cvsroot/pgsql/src/backend/parser/parse_type.c,v 1.31 2000/06/06 16:50:37 tgl Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -48,7 +48,8 @@ typeidTypeName(Oid id)
 		return NULL;
 	}
 	typetuple = (Form_pg_type) GETSTRUCT(tup);
-	return NameStr(typetuple->typname);
+	/* pstrdup here because result may need to outlive the syscache entry */
+	return pstrdup(NameStr(typetuple->typname));
 }
 
 /* return a Type structure, given a type id */
@@ -119,7 +120,8 @@ typeTypeName(Type t)
 	Form_pg_type typ;
 
 	typ = (Form_pg_type) GETSTRUCT(t);
-	return NameStr(typ->typname);
+	/* pstrdup here because result may need to outlive the syscache entry */
+	return pstrdup(NameStr(typ->typname));
 }
 
 /* given a type, return its typetype ('c' for 'c'atalog types) */

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@`
`8`	`8`	`*`
`9`	`9`	`*`
`10`	`10`	`* IDENTIFICATION`
`11`		`- * $Header: /cvsroot/pgsql/src/backend/parser/parse_type.c,v 1.30 2000/05/30 04:24:49 tgl Exp $`
	`11`	`+ * $Header: /cvsroot/pgsql/src/backend/parser/parse_type.c,v 1.31 2000/06/06 16:50:37 tgl Exp $`
`12`	`12`	`*`
`13`	`13`	`*-------------------------------------------------------------------------`
`14`	`14`	`*/`
`@@ -48,7 +48,8 @@ typeidTypeName(Oid id)`
`48`	`48`	`return NULL;`
`49`	`49`	`}`
`50`	`50`	`typetuple = (Form_pg_type) GETSTRUCT(tup);`
`51`		`- return NameStr(typetuple->typname);`
	`51`	`+ /* pstrdup here because result may need to outlive the syscache entry */`
	`52`	`+ return pstrdup(NameStr(typetuple->typname));`
`52`	`53`	`}`
`53`	`54`
`54`	`55`	`/* return a Type structure, given a type id */`
`@@ -119,7 +120,8 @@ typeTypeName(Type t)`
`119`	`120`	`Form_pg_type typ;`
`120`	`121`
`121`	`122`	`typ = (Form_pg_type) GETSTRUCT(t);`
`122`		`- return NameStr(typ->typname);`
	`123`	`+ /* pstrdup here because result may need to outlive the syscache entry */`
	`124`	`+ return pstrdup(NameStr(typ->typname));`
`123`	`125`	`}`
`124`	`126`
`125`	`127`	`/* given a type, return its typetype ('c' for 'c'atalog types) */`