Fix test case instability introduced in 085b6b6.

tglsfdc · tglsfdc · commit 064e029e60a5 · 2020-03-11T18:24:15.000-04:00
I forgot that the WAL directory might hold other files besides WAL
segments, notably including new segments still being filled.
That means a blind test for the first file's size being 16MB can
fail.  Restrict based on file name length to make it more robust.

Per buildfarm.
diff --git a/src/test/regress/expected/misc_functions.out b/src/test/regress/expected/misc_functions.out
@@ -170,7 +170,8 @@ select count(*) > 0 as ok from (select * from pg_ls_waldir() limit 1) ss;
  t
 (1 row)
 
-select (pg_ls_waldir()).size = :segbsize * :bsize as ok limit 1;
+select (w).size = :segbsize * :bsize as ok
+from (select pg_ls_waldir() w) ss where length((w).name) = 24 limit 1;
  ok 
 ----
  t
diff --git a/src/test/regress/sql/misc_functions.sql b/src/test/regress/sql/misc_functions.sql
@@ -49,4 +49,5 @@ select count(*) > 0 as ok from (select pg_ls_waldir()) ss;
 -- Test not-run-to-completion cases.
 select * from pg_ls_waldir() limit 0;
 select count(*) > 0 as ok from (select * from pg_ls_waldir() limit 1) ss;
-select (pg_ls_waldir()).size = :segbsize * :bsize as ok limit 1;
+select (w).size = :segbsize * :bsize as ok
+from (select pg_ls_waldir() w) ss where length((w).name) = 24 limit 1;

Original file line number	Diff line number	Diff line change
`@@ -170,7 +170,8 @@ select count() > 0 as ok from (select from pg_ls_waldir() limit 1) ss;`
`170`	`170`	`t`
`171`	`171`	`(1 row)`
`172`	`172`
`173`		`-select (pg_ls_waldir()).size = :segbsize * :bsize as ok limit 1;`
	`173`	`+select (w).size = :segbsize * :bsize as ok`
	`174`	`+from (select pg_ls_waldir() w) ss where length((w).name) = 24 limit 1;`
`174`	`175`	`ok`
`175`	`176`	`----`
`176`	`177`	`t`