Lexer defended us against overlength plain identifiers, but not against

tglsfdc · tglsfdc · commit 0672a3c08114 · 2000-06-01T22:21:05.000Z
overlength quoted identifiers.  Death and destruction ensue...
diff --git a/src/backend/parser/scan.l b/src/backend/parser/scan.l
@@ -9,7 +9,7 @@
  *
  *
  * IDENTIFICATION
- *	  $Header: /cvsroot/pgsql/src/backend/parser/scan.l,v 1.70 2000/05/29 05:44:54 tgl Exp $
+ *	  $Header: /cvsroot/pgsql/src/backend/parser/scan.l,v 1.71 2000/06/01 22:21:05 tgl Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -326,6 +326,12 @@ other			.
 				}
 <xd>{xdstop}	{
 					BEGIN(INITIAL);
+					if (strlen(literalbuf) >= NAMEDATALEN)
+					{
+						elog(NOTICE, "identifier \"%s\" will be truncated to \"%.*s\"",
+							 literalbuf, NAMEDATALEN-1, literalbuf);
+						literalbuf[NAMEDATALEN-1] = '\0';
+					}
 					yylval.str = pstrdup(literalbuf);
 					return IDENT;
 				}

Original file line number	Diff line number	Diff line change
`@@ -9,7 +9,7 @@`
`9`	`9`	`*`
`10`	`10`	`*`
`11`	`11`	`* IDENTIFICATION`
`12`		`- * $Header: /cvsroot/pgsql/src/backend/parser/scan.l,v 1.70 2000/05/29 05:44:54 tgl Exp $`
	`12`	`+ * $Header: /cvsroot/pgsql/src/backend/parser/scan.l,v 1.71 2000/06/01 22:21:05 tgl Exp $`
`13`	`13`	`*`
`14`	`14`	`*-------------------------------------------------------------------------`
`15`	`15`	`*/`
`@@ -326,6 +326,12 @@ other .`
`326`	`326`	`}`
`327`	`327`	`<xd>{xdstop} {`
`328`	`328`	`BEGIN(INITIAL);`
	`329`	`+ if (strlen(literalbuf) >= NAMEDATALEN)`
	`330`	`+ {`
	`331`	`+ elog(NOTICE, "identifier \"%s\" will be truncated to \"%.*s\"",`
	`332`	`+ literalbuf, NAMEDATALEN-1, literalbuf);`
	`333`	`+ literalbuf[NAMEDATALEN-1] = '\0';`
	`334`	`+ }`
`329`	`335`	`yylval.str = pstrdup(literalbuf);`
`330`	`336`	`return IDENT;`
`331`	`337`	`}`