Fix potential for compiler warning in GlobalVisTestFor().

anarazel · anarazel · commit 0d0bbee5e3ee · 2021-09-13T16:50:10.000-07:00
In d9d8aa9 I added a defensive NULL assignment to protect against a not-too-smart compiler warning about unitialized variable use after the switch. Unfortunately I only did so on master and forgot to adjust that for 14. Stephen noticed that there actually is a compiler warning :(. Reported-By: Stephen Frost <sfrost@snowman.net> Discussion: https://postgr.es/m/20210827224639.GX17906@tamriel.snowman.net
diff --git a/src/backend/storage/ipc/procarray.c b/src/backend/storage/ipc/procarray.c
@@ -4027,7 +4027,7 @@ DisplayXidCache(void)
 GlobalVisState *
 GlobalVisTestFor(Relation rel)
 {
-	GlobalVisState *state;
+	GlobalVisState *state = NULL;
 
 	/* XXX: we should assert that a snapshot is pushed or registered */
 	Assert(RecentXmin);

Original file line number	Diff line number	Diff line change
`@@ -4027,7 +4027,7 @@ DisplayXidCache(void)`
`4027`	`4027`	`GlobalVisState *`
`4028`	`4028`	`GlobalVisTestFor(Relation rel)`
`4029`	`4029`	`{`
`4030`		`- GlobalVisState *state;`
	`4030`	`+ GlobalVisState *state = NULL;`
`4031`	`4031`
`4032`	`4032`	`/* XXX: we should assert that a snapshot is pushed or registered */`
`4033`	`4033`	`Assert(RecentXmin);`