Add CHECK_FOR_INTERRUPTS while restoring changes during decoding.

Amit Kapila · pull[bot] · commit 0e129f7f7ba9 · 2023-07-03T20:20:14.000Z
Previously in commit 42681df, we added CFI during decoding changes but missed another similar case that can happen while restoring changes spilled to disk back into memory in a loop. Reported-by: Robert Haas Author: Amit Kapila Backpatch-through: 10 Discussion: https://postgr.es/m/CA+TgmoaLObg0QbstbC8ykDwOdD1bDkr4AbPpB=0DPgA2JW0mFg@mail.gmail.com
diff --git a/src/backend/replication/logical/reorderbuffer.c b/src/backend/replication/logical/reorderbuffer.c
@@ -4171,6 +4171,8 @@ ReorderBufferRestoreChanges(ReorderBuffer *rb, ReorderBufferTXN *txn,
 		int			readBytes;
 		ReorderBufferDiskChange *ondisk;
 
+		CHECK_FOR_INTERRUPTS();
+
 		if (*fd == -1)
 		{
 			char		path[MAXPGPATH];

Original file line number	Diff line number	Diff line change
`@@ -4171,6 +4171,8 @@ ReorderBufferRestoreChanges(ReorderBuffer rb, ReorderBufferTXN txn,`
`4171`	`4171`	`int readBytes;`
`4172`	`4172`	`ReorderBufferDiskChange *ondisk;`
`4173`	`4173`
	`4174`	`+ CHECK_FOR_INTERRUPTS();`
	`4175`	`+`
`4174`	`4176`	`if (*fd == -1)`
`4175`	`4177`	`{`
`4176`	`4178`	`char path[MAXPGPATH];`