Skip to content

Commit 15903a1

Browse files
bmomjianbmomjian
committed
Comment improvements.
1 parent be92ad4 commit 15903a1

File tree

4 files changed

+20
-14
lines changed

4 files changed

+20
-14
lines changed

‎src/include/access/htup.h

Lines changed: 11 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* Portions Copyright (c) 1996-2001, PostgreSQL Global Development Group
88
* Portions Copyright (c) 1994, Regents of the University of California
99
*
10-
* $Id: htup.h,v 1.45 2001/01/24 19:43:19 momjian Exp $
10+
* $Id: htup.h,v 1.46 2001/02/21 19:07:04 momjian Exp $
1111
*
1212
*-------------------------------------------------------------------------
1313
*/
@@ -32,7 +32,9 @@
3232
#define MaxHeapAttributeNumber 1600 /* 8 * 200 */
3333

3434
/*
35-
* to avoid wasting space, the attributes should be layed out in such a
35+
* This is the on-disk copy of the tuple.
36+
*
37+
* To avoid wasting space, the attributes should be layed out in such a
3638
* way to reduce structure padding.
3739
*/
3840
typedef struct HeapTupleHeaderData
@@ -51,12 +53,12 @@ typedef struct HeapTupleHeaderData
5153

5254
uint16 t_infomask; /* various infos */
5355

54-
uint8 t_hoff; /* sizeof tuple header */
56+
uint8 t_hoff; /* sizeof() tuple header */
5557

5658
/* ^ - 31 bytes - ^ */
5759

5860
bits8 t_bits[MinHeapTupleBitmapSize / 8];
59-
/* bit map of domains */
61+
/* bit map of NULLs */
6062

6163
/* MORE DATA FOLLOWS AT END OF STRUCT */
6264
} HeapTupleHeaderData;
@@ -174,6 +176,8 @@ typedef struct xl_heap_clean
174176
#define FirstLowInvalidHeapAttributeNumber (-8)
175177

176178
/*
179+
* This is the in-memory copy of the tuple.
180+
*
177181
* This new HeapTuple for version >= 6.5 and this is why it was changed:
178182
*
179183
* 1. t_len moved off on-disk tuple data - ItemIdData is used to get len;
@@ -190,10 +194,10 @@ typedef struct xl_heap_clean
190194
typedef struct HeapTupleData
191195
{
192196
uint32 t_len; /* length of *t_data */
193-
ItemPointerData t_self; /* SelfItemPointer */
197+
ItemPointerData t_self; /* SelfItemPointer */
194198
Oid t_tableOid; /* table the tuple came from */
195-
MemoryContext t_datamcxt; /* mcxt in which allocated */
196-
HeapTupleHeader t_data; /* -> tuple header and data */
199+
MemoryContext t_datamcxt; /* memory context of allocation */
200+
HeapTupleHeader t_data; /* -> tuple header and data */
197201
} HeapTupleData;
198202

199203
typedef HeapTupleData *HeapTuple;

‎src/include/access/itup.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* Portions Copyright (c) 1996-2001, PostgreSQL Global Development Group
88
* Portions Copyright (c) 1994, Regents of the University of California
99
*
10-
* $Id: itup.h,v 1.28 2001/01/24 19:43:19 momjian Exp $
10+
* $Id: itup.h,v 1.29 2001/02/21 19:07:04 momjian Exp $
1111
*
1212
*-------------------------------------------------------------------------
1313
*/
@@ -22,7 +22,7 @@
2222

2323
typedef struct IndexTupleData
2424
{
25-
ItemPointerData t_tid; /* reference TID to base tuple */
25+
ItemPointerData t_tid; /* reference TID to heap tuple */
2626

2727
/*
2828
* t_info is layed out in the following fashion:

‎src/include/access/nbtree.h

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* Portions Copyright (c) 1996-2001, PostgreSQL Global Development Group
88
* Portions Copyright (c) 1994, Regents of the University of California
99
*
10-
* $Id: nbtree.h,v 1.51 2001/02/07 23:34:18 vadim Exp $
10+
* $Id: nbtree.h,v 1.52 2001/02/21 19:07:04 momjian Exp $
1111
*
1212
*-------------------------------------------------------------------------
1313
*/
@@ -37,15 +37,17 @@ typedef struct BTPageOpaqueData
3737
BlockNumber btpo_parent;
3838
uint16 btpo_flags;
3939

40+
} BTPageOpaqueData;
41+
42+
typedef BTPageOpaqueData *BTPageOpaque;
43+
4044
/* Bits defined in btpo_flags */
4145
#define BTP_LEAF (1 << 0) /* It's a leaf page */
4246
#define BTP_ROOT (1 << 1) /* It's the root page (has no parent) */
4347
#define BTP_FREE (1 << 2) /* not currently used... */
4448
#define BTP_META (1 << 3) /* Set in the meta-page only */
4549
#define BTP_REORDER (1 << 4) /* items must be re-ordered */
46-
} BTPageOpaqueData;
4750

48-
typedef BTPageOpaqueData *BTPageOpaque;
4951

5052
#define BTREE_METAPAGE 0 /* first page is meta */
5153
#define BTREE_MAGIC 0x053162

‎src/include/storage/bufpage.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* Portions Copyright (c) 1996-2001, PostgreSQL Global Development Group
88
* Portions Copyright (c) 1994, Regents of the University of California
99
*
10-
* $Id: bufpage.h,v 1.39 2001/01/24 19:43:27 momjian Exp $
10+
* $Id: bufpage.h,v 1.40 2001/02/21 19:07:04 momjian Exp $
1111
*
1212
*-------------------------------------------------------------------------
1313
*/
@@ -23,7 +23,7 @@
2323
#include "access/xlog.h"
2424

2525
/*
26-
* a postgres disk page is an abstraction layered on top of a postgres
26+
* A postgres disk page is an abstraction layered on top of a postgres
2727
* disk block (which is simply a unit of i/o, see block.h).
2828
*
2929
* specifically, while a disk block can be unformatted, a postgres

0 commit comments

Comments
 (0)