Fix leak of LLVM "fatal-on-oom" section counter.

hlinnaka · hlinnaka · commit 162aa47c31a0 · 2023-07-05T13:14:24.000+03:00
llvm_release_context() called llvm_enter_fatal_on_oom(), but was missing the corresponding llvm_leave_fatal_on_oom() call. As a result, if JIT was used at all, we were almost always in the "fatal-on-oom" state. It only makes a difference if you use an extension written in C++, and run out of memory in a C++ 'new' call. In that case, you would get a PostgreSQL FATAL error, instead of the default behavior of throwing a C++ exception. Back-patch to all supported versions. Reviewed-by: Daniel Gustafsson Discussion: https://www.postgresql.org/message-id/54b78cca-bc84-dad8-4a7e-5b56f764fab5@iki.fi
diff --git a/src/backend/jit/llvm/llvmjit.c b/src/backend/jit/llvm/llvmjit.c
@@ -233,6 +233,8 @@ llvm_release_context(JitContext *context)
 
 		pfree(jit_handle);
 	}
+
+	llvm_leave_fatal_on_oom();
 }
 
 /*

Original file line number	Diff line number	Diff line change
`@@ -233,6 +233,8 @@ llvm_release_context(JitContext *context)`
`233`	`233`
`234`	`234`	`pfree(jit_handle);`
`235`	`235`	`}`
	`236`	`+`
	`237`	`+ llvm_leave_fatal_on_oom();`
`236`	`238`	`}`
`237`	`239`
`238`	`240`	`/*`