Fix incorrect logic in plan dependency recording

david-rowley · david-rowley · commit 1a6900e58ae2 · 2023-09-14T11:27:16.000+12:00
Both 50e17ad and 29f45e2 mistakenly tried to record a plan dependency on a function but mistakenly inverted the OidIsValid test. This meant that we'd record a dependency only when the function's Oid was InvalidOid. Clearly this was meant to *not* record the dependency in that case. 50e17ad made this mistake first, then in v15 29f45e2 copied the same mistake. Reported-by: Tom Lane Backpatch-through: 14, where 50e17ad first made this mistake Discussion: https://postgr.es/m/2277537.1694301772@sss.pgh.pa.us
diff --git a/src/backend/optimizer/plan/setrefs.c b/src/backend/optimizer/plan/setrefs.c
@@ -1979,10 +1979,10 @@ fix_expr_common(PlannerInfo *root, Node *node)
 		set_sa_opfuncid(saop);
 		record_plan_function_dependency(root, saop->opfuncid);
 
-		if (!OidIsValid(saop->hashfuncid))
+		if (OidIsValid(saop->hashfuncid))
 			record_plan_function_dependency(root, saop->hashfuncid);
 
-		if (!OidIsValid(saop->negfuncid))
+		if (OidIsValid(saop->negfuncid))
 			record_plan_function_dependency(root, saop->negfuncid);
 	}
 	else if (IsA(node, Const))
