Fix unportable usage of <ctype.h> functions.

tglsfdc · tglsfdc · commit 1a93c2536a75 · 2017-11-07T13:49:54.000-05:00
isdigit(), isspace(), etc are likely to give surprising results if passed a signed char. We should always cast the argument to unsigned char to avoid that. Error in commit 63d6b97, found by buildfarm member gaur. Back-patch to 9.3, like that commit.
diff --git a/src/interfaces/ecpg/ecpglib/data.c b/src/interfaces/ecpg/ecpglib/data.c
@@ -59,7 +59,7 @@ garbage_left(enum ARRAY_TYPE isarray, char **scan_length, enum COMPAT_MODE compa
 			/* skip invalid characters */
 			do {
 				(*scan_length)++;
-			} while (isdigit(**scan_length));
+			} while (isdigit((unsigned char) **scan_length));
 		}
 
 		if (**scan_length != ' ' && **scan_length != '\0')

Original file line number	Diff line number	Diff line change
`@@ -59,7 +59,7 @@ garbage_left(enum ARRAY_TYPE isarray, char **scan_length, enum COMPAT_MODE compa`
`59`	`59`	`/* skip invalid characters */`
`60`	`60`	`do {`
`61`	`61`	`(*scan_length)++;`
`62`		`- } while (isdigit(**scan_length));`
	`62`	`+ } while (isdigit((unsigned char) **scan_length));`
`63`	`63`	`}`
`64`	`64`
`65`	`65`	`if (scan_length != ' ' && scan_length != '\0')`