Got tired of explaining why this Assert is not wrong.

tglsfdc · tglsfdc · commit 1ce069b067f5 · 2002-10-31T21:59:32.000Z
diff --git a/src/backend/utils/hash/dynahash.c b/src/backend/utils/hash/dynahash.c
@@ -9,7 +9,7 @@
  *
  *
  * IDENTIFICATION
- *	  $Header: /cvsroot/pgsql/src/backend/utils/hash/dynahash.c,v 1.44 2002/09/02 02:47:05 momjian Exp $
+ *	  $Header: /cvsroot/pgsql/src/backend/utils/hash/dynahash.c,v 1.45 2002/10/31 21:59:32 tgl Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -540,7 +540,8 @@ hash_search(HTAB *hashp,
 		/*
 		 * Try to catch subsequent errors
 		 */
-		Assert(currBucket && !(saveState.currBucket = NULL));
+		Assert(currBucket);
+		saveState.currBucket = NULL;
 	}
 	else
 	{

Original file line number	Diff line number	Diff line change
`@@ -9,7 +9,7 @@`
`9`	`9`	`*`
`10`	`10`	`*`
`11`	`11`	`* IDENTIFICATION`
`12`		`- * $Header: /cvsroot/pgsql/src/backend/utils/hash/dynahash.c,v 1.44 2002/09/02 02:47:05 momjian Exp $`
	`12`	`+ * $Header: /cvsroot/pgsql/src/backend/utils/hash/dynahash.c,v 1.45 2002/10/31 21:59:32 tgl Exp $`
`13`	`13`	`*`
`14`	`14`	`*-------------------------------------------------------------------------`
`15`	`15`	`*/`
`@@ -540,7 +540,8 @@ hash_search(HTAB *hashp,`
`540`	`540`	`/*`
`541`	`541`	`* Try to catch subsequent errors`
`542`	`542`	`*/`
`543`		`- Assert(currBucket && !(saveState.currBucket = NULL));`
	`543`	`+ Assert(currBucket);`
	`544`	`+ saveState.currBucket = NULL;`
`544`	`545`	`}`
`545`	`546`	`else`
`546`	`547`	`{`