Fix buffer overflow on particularly named files and clarify documentation about

Michael Meskes · Michael Meskes · commit 1df8b3fe820d · 2016-12-22T08:32:25.000+01:00
output file naming.

Patch by Tsunakawa, Takayuki &lt;tsunakawa.takay@jp.fujitsu.com&gt;
diff --git a/doc/src/sgml/ref/ecpg-ref.sgml b/doc/src/sgml/ref/ecpg-ref.sgml
@@ -42,11 +42,9 @@ PostgreSQL documentation
   <para>
    <command>ecpg</command> will convert each input file given on the
    command line to the corresponding C output file.  Input files
-   preferably have the extension <filename>.pgc</filename>, in which
-   case the extension will be replaced by <filename>.c</filename> to
-   determine the output file name.  If the extension of the input file
-   is not <filename>.pgc</filename>, then the output file name is
-   computed by appending <literal>.c</literal> to the full file name.
+   preferably have the extension <filename>.pgc</filename>.
+   The extension will be replaced by <filename>.c</filename> to
+   determine the output file name.
    The output file name can also be overridden using the
    <option>-o</option> option.
   </para>
diff --git a/src/interfaces/ecpg/preproc/ecpg.c b/src/interfaces/ecpg/preproc/ecpg.c
@@ -309,7 +309,8 @@ main(int argc, char *const argv[])
 					base_yyout = stdout;
 				else
 				{
-					output_filename = strdup(input_filename);
+					output_filename = mm_alloc(strlen(input_filename) + 3);
+					strcpy(output_filename, input_filename);
 
 					ptr2ext = strrchr(output_filename, '.');
 					/* make extension = .c resp. .h */

Original file line number	Diff line number	Diff line change
`@@ -309,7 +309,8 @@ main(int argc, char *const argv[])`
`309`	`309`	`base_yyout = stdout;`
`310`	`310`	`else`
`311`	`311`	`{`
`312`		`- output_filename = strdup(input_filename);`
	`312`	`+ output_filename = mm_alloc(strlen(input_filename) + 3);`
	`313`	`+ strcpy(output_filename, input_filename);`
`313`	`314`
`314`	`315`	`ptr2ext = strrchr(output_filename, '.');`
`315`	`316`	`/* make extension = .c resp. .h */`