Skip to content

Commit 259489b

Browse files
author
Thomas G. Lockhart
committed
Implement LIKE/ESCAPE. Change parser to use like()/notlike()
rather than the "~~" operator; this made it easy to add ESCAPE features. Implement ILIKE, NOT ILIKE, and the ESCAPE clause for them. afaict this is not MultiByte clean, but lots of other stuff isn't either. Fix up underlying support code for LIKE/NOT LIKE. Things should be faster and does not require internal string copying. Update regression test to add explicit checks for LIKE/NOT LIKE/ILIKE/NOT ILIKE. Remove colon and semi-colon operators as threatened in 7.0. Implement SQL99 COMMIT/AND NO CHAIN. Throw elog(ERROR) on COMMIT/AND CHAIN per spec since we don't yet support it. Implement SQL99 CREATE/DROP SCHEMA as equivalent to CREATE DATABASE. This is only a stopgap or demo since schemas will have another implementation soon. Remove a few unused production rules to get rid of warnings which crept in on the last commit. Fix up tabbing in some places by removing embedded spaces.
1 parent 30ab107 commit 259489b

File tree

1 file changed

+101
-8
lines changed

1 file changed

+101
-8
lines changed

src/test/regress/sql/strings.sql

Lines changed: 101 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -41,21 +41,114 @@ SELECT CAST(name 'namefield' AS varchar) AS "varchar(name)";
4141
-- test SQL92 string functions
4242
--
4343

44-
SELECT TRIM(BOTH FROM ' bunch o blanks ') AS "bunch o blanks";
44+
SELECT TRIM(BOTH FROM ' bunch o blanks ') = 'bunch o blanks' AS "bunch o blanks";
4545

46-
SELECT TRIM(LEADING FROM ' bunch o blanks ') AS "bunch o blanks ";
46+
SELECT TRIM(LEADING FROM ' bunch o blanks ') = 'bunch o blanks ' AS "bunch o blanks ";
4747

48-
SELECT TRIM(TRAILING FROM ' bunch o blanks ') AS " bunch o blanks";
48+
SELECT TRIM(TRAILING FROM ' bunch o blanks ') = ' bunch o blanks' AS " bunch o blanks";
4949

50-
SELECT TRIM(BOTH 'x' FROM 'xxxxxsome Xsxxxxx') AS "some Xs";
50+
SELECT TRIM(BOTH 'x' FROM 'xxxxxsome Xsxxxxx') = 'some Xs' AS "some Xs";
5151

52-
SELECT SUBSTRING('1234567890' FROM 3) AS "34567890";
52+
SELECT SUBSTRING('1234567890' FROM 3) = '34567890' AS "34567890";
5353

54-
SELECT SUBSTRING('1234567890' FROM 4 FOR 3) AS "456";
54+
SELECT SUBSTRING('1234567890' FROM 4 FOR 3) = '456' AS "456";
5555

56-
SELECT POSITION('4' IN '1234567890') AS "4";
56+
SELECT POSITION('4' IN '1234567890') = '4' AS "4";
5757

58-
SELECT POSITION(5 IN '1234567890') AS "5";
58+
SELECT POSITION(5 IN '1234567890') = '5' AS "5";
59+
60+
--
61+
-- test LIKE
62+
-- Be sure to form every test as a LIKE/NOT LIKE pair.
63+
--
64+
65+
-- simplest examples
66+
SELECT 'hawkeye' LIKE 'h%' AS "true";
67+
SELECT 'hawkeye' NOT LIKE 'h%' AS "false";
68+
69+
SELECT 'hawkeye' LIKE 'H%' AS "false";
70+
SELECT 'hawkeye' NOT LIKE 'H%' AS "true";
71+
72+
SELECT 'hawkeye' LIKE 'indio%' AS "false";
73+
SELECT 'hawkeye' NOT LIKE 'indio%' AS "true";
74+
75+
SELECT 'hawkeye' LIKE 'h%eye' AS "true";
76+
SELECT 'hawkeye' NOT LIKE 'h%eye' AS "false";
77+
78+
SELECT 'indio' LIKE '_ndio' AS "true";
79+
SELECT 'indio' NOT LIKE '_ndio' AS "false";
80+
81+
SELECT 'indio' LIKE 'in__o' AS "true";
82+
SELECT 'indio' NOT LIKE 'in__o' AS "false";
83+
84+
SELECT 'indio' LIKE 'in_o' AS "false";
85+
SELECT 'indio' NOT LIKE 'in_o' AS "true";
86+
87+
-- unused escape character
88+
SELECT 'hawkeye' LIKE 'h%' ESCAPE '#' AS "true";
89+
SELECT 'hawkeye' NOT LIKE 'h%' ESCAPE '#' AS "false";
90+
91+
SELECT 'indio' LIKE 'ind_o' ESCAPE '$' AS "true";
92+
SELECT 'indio' NOT LIKE 'ind_o' ESCAPE '$' AS "false";
93+
94+
-- escape character
95+
SELECT 'h%' LIKE 'h#%' ESCAPE '#' AS "true";
96+
SELECT 'h%' NOT LIKE 'h#%' ESCAPE '#' AS "false";
97+
98+
SELECT 'h%wkeye' LIKE 'h#%' ESCAPE '#' AS "false";
99+
SELECT 'h%wkeye' NOT LIKE 'h#%' ESCAPE '#' AS "true";
100+
101+
SELECT 'h%wkeye' LIKE 'h#%%' ESCAPE '#' AS "true";
102+
SELECT 'h%wkeye' NOT LIKE 'h#%%' ESCAPE '#' AS "false";
103+
104+
SELECT 'h%awkeye' LIKE 'h#%a%k%e' ESCAPE '#' AS "true";
105+
SELECT 'h%awkeye' NOT LIKE 'h#%a%k%e' ESCAPE '#' AS "false";
106+
107+
SELECT 'indio' LIKE '_ndio' ESCAPE '$' AS "true";
108+
SELECT 'indio' NOT LIKE '_ndio' ESCAPE '$' AS "false";
109+
110+
SELECT 'i_dio' LIKE 'i$_d_o' ESCAPE '$' AS "true";
111+
SELECT 'i_dio' NOT LIKE 'i$_d_o' ESCAPE '$' AS "false";
112+
113+
SELECT 'i_dio' LIKE 'i$_nd_o' ESCAPE '$' AS "false";
114+
SELECT 'i_dio' NOT LIKE 'i$_nd_o' ESCAPE '$' AS "true";
115+
116+
SELECT 'i_dio' LIKE 'i$_d%o' ESCAPE '$' AS "true";
117+
SELECT 'i_dio' NOT LIKE 'i$_d%o' ESCAPE '$' AS "false";
118+
119+
-- escape character same as pattern character
120+
SELECT 'maca' LIKE 'm%aca' ESCAPE '%' AS "true";
121+
SELECT 'maca' NOT LIKE 'm%aca' ESCAPE '%' AS "false";
122+
123+
SELECT 'ma%a' LIKE 'm%a%%a' ESCAPE '%' AS "true";
124+
SELECT 'ma%a' NOT LIKE 'm%a%%a' ESCAPE '%' AS "false";
125+
126+
SELECT 'bear' LIKE 'b_ear' ESCAPE '_' AS "true";
127+
SELECT 'bear' NOT LIKE 'b_ear' ESCAPE '_' AS "false";
128+
129+
SELECT 'be_r' LIKE 'b_e__r' ESCAPE '_' AS "true";
130+
SELECT 'be_r' NOT LIKE 'b_e__r' ESCAPE '_' AS "false";
131+
132+
SELECT 'be_r' LIKE '__e__r' ESCAPE '_' AS "false";
133+
SELECT 'be_r' NOT LIKE '__e__r' ESCAPE '_' AS "true";
134+
135+
136+
--
137+
-- test ILIKE (case-insensitive LIKE)
138+
-- Be sure to form every test as an ILIKE/NOT ILIKE pair.
139+
--
140+
141+
SELECT 'hawkeye' ILIKE 'h%' AS "true";
142+
SELECT 'hawkeye' NOT ILIKE 'h%' AS "false";
143+
144+
SELECT 'hawkeye' ILIKE 'H%' AS "true";
145+
SELECT 'hawkeye' NOT ILIKE 'H%' AS "false";
146+
147+
SELECT 'hawkeye' ILIKE 'H%Eye' AS "true";
148+
SELECT 'hawkeye' NOT ILIKE 'H%Eye' AS "false";
149+
150+
SELECT 'Hawkeye' ILIKE 'h%' AS "true";
151+
SELECT 'Hawkeye' NOT ILIKE 'h%' AS "false";
59152

60153
--
61154
-- test implicit type conversion

0 commit comments

Comments
 (0)