There is a problem in the Makefile of libpgtcl on linux (and maybe also on

scrappy · scrappy · commit 2768f391a4d9 · 1996-11-08T00:58:07.000Z
other platforms).  If I do the standard make + make install the shared library
is not linked with the the libpq library and when I try to load it in the
standard Tcl or Tk shell I get a lot of unresolved symbols.  The bug doesn't
affect pgtclsh because it is linked also with libpq. The problem exists only
when using the dynamic load feature of Tcl7.5.


From: Massimo Dal Zotto &lt;dz@cs.unitn.it&gt;
diff --git a/src/interfaces/libpgtcl/Makefile b/src/interfaces/libpgtcl/Makefile
@@ -7,7 +7,7 @@
 #
 #
 # IDENTIFICATION
-#    $Header: /cvsroot/pgsql/src/interfaces/libpgtcl/Attic/Makefile,v 1.3 1996/10/30 06:18:36 scrappy Exp $
+#    $Header: /cvsroot/pgsql/src/interfaces/libpgtcl/Attic/Makefile,v 1.4 1996/11/08 00:58:07 scrappy Exp $
 #
 #-------------------------------------------------------------------------
 
@@ -29,6 +29,11 @@ ifdef KRBVERS
 CFLAGS+= $(KRBFLAGS)
 endif
 
+ifdef LINUX_ELF
+CFLAGS += -fPIC
+CC += -L $(POSTGRESDIR)/lib -lpq
+endif
+
 LIBSRCS= pgtcl.c pgtclCmds.c pgtclId.c
 
 install-headers:

Original file line number	Diff line number	Diff line change
`@@ -7,7 +7,7 @@`
`7`	`7`	`#`
`8`	`8`	`#`
`9`	`9`	`# IDENTIFICATION`
`10`		`-# $Header: /cvsroot/pgsql/src/interfaces/libpgtcl/Attic/Makefile,v 1.3 1996/10/30 06:18:36 scrappy Exp $`
	`10`	`+# $Header: /cvsroot/pgsql/src/interfaces/libpgtcl/Attic/Makefile,v 1.4 1996/11/08 00:58:07 scrappy Exp $`
`11`	`11`	`#`
`12`	`12`	`#-------------------------------------------------------------------------`
`13`	`13`
`@@ -29,6 +29,11 @@ ifdef KRBVERS`
`29`	`29`	`CFLAGS+= $(KRBFLAGS)`
`30`	`30`	`endif`
`31`	`31`
	`32`	`+ifdef LINUX_ELF`
	`33`	`+CFLAGS += -fPIC`
	`34`	`+CC += -L $(POSTGRESDIR)/lib -lpq`
	`35`	`+endif`
	`36`	`+`
`32`	`37`	`LIBSRCS= pgtcl.c pgtclCmds.c pgtclId.c`
`33`	`38`
`34`	`39`	`install-headers:`