Fix bogus sizeof calculations.

tglsfdc · tglsfdc · commit 27bc87985c41 · 2019-09-15T11:51:57.000-04:00
Noted by Coverity. Typo in 27cc7cd, so back-patch to v12 as that was.
diff --git a/src/backend/executor/execMain.c b/src/backend/executor/execMain.c
@@ -2917,7 +2917,7 @@ EvalPlanQualStart(EPQState *epqstate, Plan *planTree)
 	{
 		Assert(epqstate->relsubs_done != NULL);
 		memset(epqstate->relsubs_rowmark, 0,
-			   sizeof(rtsize * sizeof(ExecAuxRowMark *)));
+			   rtsize * sizeof(ExecAuxRowMark *));
 		memset(epqstate->relsubs_done, 0,
 			   rtsize * sizeof(bool));
 	}
@@ -2971,7 +2971,7 @@ EvalPlanQualEnd(EPQState *epqstate)
 	if (epqstate->tuple_table != NIL)
 	{
 		memset(epqstate->relsubs_slot, 0,
-			   sizeof(rtsize * sizeof(TupleTableSlot *)));
+			   rtsize * sizeof(TupleTableSlot *));
 		ExecResetTupleTable(epqstate->tuple_table, true);
 		epqstate->tuple_table = NIL;
 	}

Original file line number	Diff line number	Diff line change
`@@ -2917,7 +2917,7 @@ EvalPlanQualStart(EPQState epqstate, Plan planTree)`
`2917`	`2917`	`{`
`2918`	`2918`	`Assert(epqstate->relsubs_done != NULL);`
`2919`	`2919`	`memset(epqstate->relsubs_rowmark, 0,`
`2920`		`- sizeof(rtsize * sizeof(ExecAuxRowMark *)));`
	`2920`	`+ rtsize * sizeof(ExecAuxRowMark *));`
`2921`	`2921`	`memset(epqstate->relsubs_done, 0,`
`2922`	`2922`	`rtsize * sizeof(bool));`
`2923`	`2923`	`}`
`@@ -2971,7 +2971,7 @@ EvalPlanQualEnd(EPQState *epqstate)`
`2971`	`2971`	`if (epqstate->tuple_table != NIL)`
`2972`	`2972`	`{`
`2973`	`2973`	`memset(epqstate->relsubs_slot, 0,`
`2974`		`- sizeof(rtsize * sizeof(TupleTableSlot *)));`
	`2974`	`+ rtsize * sizeof(TupleTableSlot *));`
`2975`	`2975`	`ExecResetTupleTable(epqstate->tuple_table, true);`
`2976`	`2976`	`epqstate->tuple_table = NIL;`
`2977`	`2977`	`}`