fsync pg_logical/mappings in CheckPointLogicalRewriteHeap().

anarazel · anarazel · commit 2b7dbe4bd587 · 2022-01-21T11:24:12.000-08:00
While individual logical rewrite files were synced to disk, the directory was not. On some filesystems that could lead to loosing directory entries after a crash. Reported-By: Tom Lane <tgl@sss.pgh.pa.us> Author: Nathan Bossart <bossartn@amazon.com> Discussion: https://postgr.es/m/867F2E29-2782-4869-970E-B984C6D35A8F@amazon.com Backpatch: 10-
diff --git a/src/backend/access/heap/rewriteheap.c b/src/backend/access/heap/rewriteheap.c
@@ -1289,4 +1289,7 @@ CheckPointLogicalRewriteHeap(void)
 		}
 	}
 	FreeDir(mappings_dir);
+
+	/* persist directory entries to disk */
+	fsync_fname("pg_logical/mappings", true);
 }

Original file line number	Diff line number	Diff line change
`@@ -1289,4 +1289,7 @@ CheckPointLogicalRewriteHeap(void)`
`1289`	`1289`	`}`
`1290`	`1290`	`}`
`1291`	`1291`	`FreeDir(mappings_dir);`
	`1292`	`+`
	`1293`	`+ /* persist directory entries to disk */`
	`1294`	`+ fsync_fname("pg_logical/mappings", true);`
`1292`	`1295`	`}`