psql: Fix display of whether table is part of publication

petere · petere · commit 2d460179baa8 · 2017-06-01T21:17:01.000-04:00
If a FOR ALL TABLES publication was present, \d of a table would claim
for each table that it was part of the publication, even for tables that
are ignored for this purpose, such as system tables and unlogged tables.
Fix the query by using the function pg_get_publication_tables(), which
was intended for this purpose.

Reported-by: tushar &lt;tushar.ahuja@enterprisedb.com&gt;
Reviewed-by: Amit Langote &lt;Langote_Amit_f8@lab.ntt.co.jp&gt;
Reviewed-by: Kuntal Ghosh &lt;kuntalghosh.2007@gmail.com&gt;
diff --git a/src/bin/psql/describe.c b/src/bin/psql/describe.c
@@ -2537,10 +2537,9 @@ describeOneTableDetails(const char *schemaname,
 		{
 			printfPQExpBuffer(&buf,
 							  "SELECT pub.pubname\n"
-							  " FROM pg_catalog.pg_publication pub\n"
-							  " LEFT JOIN pg_catalog.pg_publication_rel pr\n"
-							  "      ON (pr.prpubid = pub.oid)\n"
-							  "WHERE pr.prrelid = '%s' OR pub.puballtables\n"
+							  " FROM pg_catalog.pg_publication pub,\n"
+							  "      pg_catalog.pg_get_publication_tables(pub.pubname)\n"
+							  "WHERE relid = '%s'\n"
 							  "ORDER BY 1;",
 							  oid);
 
