The second patch adds a more explicative error message to BufferPoolCheckLeak.

scrappy · scrappy · commit 37a8bdba4396 · 1997-01-23T19:43:23.000Z
It should be completely harmless.

Submitted by: Massimo Dal Zotto &lt;dz@cs.unitn.it&gt;
diff --git a/src/backend/storage/buffer/bufmgr.c b/src/backend/storage/buffer/bufmgr.c
@@ -7,7 +7,7 @@
  *
  *
  * IDENTIFICATION
- *    $Header: /cvsroot/pgsql/src/backend/storage/buffer/bufmgr.c,v 1.9 1997/01/20 04:36:48 vadim Exp $
+ *    $Header: /cvsroot/pgsql/src/backend/storage/buffer/bufmgr.c,v 1.10 1997/01/23 19:43:23 scrappy Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -1105,15 +1105,20 @@ int
 BufferPoolCheckLeak()
 {
     register int i;
+    int error = 0;
     void PrintBufferDescs();
     
     for (i = 1; i <= NBuffers; i++) {
 	if (BufferIsValid(i)) {
-	    elog(NOTICE, "buffer leak detected in BufferPoolCheckLeak()");
-	    PrintBufferDescs();
-	    return(1);
+	    elog(NOTICE, 
+                 "buffer leak [%d] detected in BufferPoolCheckLeak()", i-1);
+            error = 1;
 	}
     }
+    if(error) {
+      PrintBufferDescs();
+      return(1);
+    }
     return(0);
 }
 

Original file line number	Diff line number	Diff line change
`@@ -7,7 +7,7 @@`
`7`	`7`	`*`
`8`	`8`	`*`
`9`	`9`	`* IDENTIFICATION`
`10`		`- * $Header: /cvsroot/pgsql/src/backend/storage/buffer/bufmgr.c,v 1.9 1997/01/20 04:36:48 vadim Exp $`
	`10`	`+ * $Header: /cvsroot/pgsql/src/backend/storage/buffer/bufmgr.c,v 1.10 1997/01/23 19:43:23 scrappy Exp $`
`11`	`11`	`*`
`12`	`12`	`*-------------------------------------------------------------------------`
`13`	`13`	`*/`
`@@ -1105,15 +1105,20 @@ int`
`1105`	`1105`	`BufferPoolCheckLeak()`
`1106`	`1106`	`{`
`1107`	`1107`	`register int i;`
	`1108`	`+ int error = 0;`
`1108`	`1109`	`void PrintBufferDescs();`
`1109`	`1110`
`1110`	`1111`	`for (i = 1; i <= NBuffers; i++) {`
`1111`	`1112`	`if (BufferIsValid(i)) {`
`1112`		`- elog(NOTICE, "buffer leak detected in BufferPoolCheckLeak()");`
`1113`		`- PrintBufferDescs();`
`1114`		`- return(1);`
	`1113`	`+ elog(NOTICE,`
	`1114`	`+ "buffer leak [%d] detected in BufferPoolCheckLeak()", i-1);`
	`1115`	`+ error = 1;`
`1115`	`1116`	`}`
`1116`	`1117`	`}`
	`1118`	`+ if(error) {`
	`1119`	`+ PrintBufferDescs();`
	`1120`	`+ return(1);`
	`1121`	`+ }`
`1117`	`1122`	`return(0);`
`1118`	`1123`	`}`
`1119`	`1124`