Don't crash when pg_xlog is empty and pg_basebackup -x is used

mhagander · mhagander · commit 3979ff1fc6e9 · 2013-08-24T17:14:09.000+02:00
The backup will not work (without a logarchive, and that's the whole
point of -x) in this case, this patch just changes it to throw an
error instead of crashing when this happens.

Noticed and diagnosed by TAKATSUKA Haruka
diff --git a/src/backend/replication/basebackup.c b/src/backend/replication/basebackup.c
@@ -297,6 +297,14 @@ perform_base_backup(basebackup_options *opt, DIR *tblspcdir)
 		}
 		qsort(walFiles, nWalFiles, sizeof(char *), compareWalFileNames);
 
+		/*
+		 * There must be at least one xlog file in the pg_xlog directory,
+		 * since we are doing backup-including-xlog.
+		 */
+		if (nWalFiles < 1)
+			ereport(ERROR,
+					(errmsg("could not find any WAL files")));
+
 		/*
 		 * Sanity check: the first and last segment should cover startptr and
 		 * endptr, with no gaps in between.
