I have two small patches which correct some very obscure bug in the parser

scrappy · scrappy · commit 3c237e7347ff · 1996-09-19T20:05:59.000Z
of the array constants and in one of the loadable modules I posted some time
ago.

Submitted by: Massimo Dal Zotto &lt;dz@cs.unitn.it&gt;
diff --git a/contrib/string/string_io.c b/contrib/string/string_io.c
@@ -79,7 +79,7 @@ string_output(char *data, int size)
 	    len++;
 	    break;
 	  default:
-	    if (NOTPRINTABLE(c)) {
+	    if (NOTPRINTABLE(*p)) {
 		len += 3;
 	    }
 	}
diff --git a/src/backend/utils/adt/arrayfuncs.c b/src/backend/utils/adt/arrayfuncs.c
@@ -7,7 +7,7 @@
  *
  *
  * IDENTIFICATION
- *    $Header: /cvsroot/pgsql/src/backend/utils/adt/arrayfuncs.c,v 1.4 1996/08/27 07:32:27 scrappy Exp $
+ *    $Header: /cvsroot/pgsql/src/backend/utils/adt/arrayfuncs.c,v 1.5 1996/09/19 20:04:56 scrappy Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -235,6 +235,10 @@ _ArrayCount(char *str, int dim[], int typdelim)
                 }
                 break;
 #endif
+	    case '\0':
+		/* Signal a premature end of the string.  DZ - 2-9-1996 */
+		elog(WARN, "malformed array constant: %s", str);
+		break;
 	    case '\"':
 		scanning_string = ! scanning_string;
 		break;

Original file line number	Diff line number	Diff line change
`@@ -79,7 +79,7 @@ string_output(char *data, int size)`
`79`	`79`	`len++;`
`80`	`80`	`break;`
`81`	`81`	`default:`
`82`		`- if (NOTPRINTABLE(c)) {`
	`82`	`+ if (NOTPRINTABLE(*p)) {`
`83`	`83`	`len += 3;`
`84`	`84`	`}`
`85`	`85`	`}`
Original file line number	Diff line number	Diff line change
`@@ -7,7 +7,7 @@`
`7`	`7`	`*`
`8`	`8`	`*`
`9`	`9`	`* IDENTIFICATION`
`10`		`- * $Header: /cvsroot/pgsql/src/backend/utils/adt/arrayfuncs.c,v 1.4 1996/08/27 07:32:27 scrappy Exp $`
	`10`	`+ * $Header: /cvsroot/pgsql/src/backend/utils/adt/arrayfuncs.c,v 1.5 1996/09/19 20:04:56 scrappy Exp $`
`11`	`11`	`*`
`12`	`12`	`*-------------------------------------------------------------------------`
`13`	`13`	`*/`
`@@ -235,6 +235,10 @@ _ArrayCount(char *str, int dim[], int typdelim)`
`235`	`235`	`}`
`236`	`236`	`break;`
`237`	`237`	`#endif`
	`238`	`+ case '\0':`
	`239`	`+ /* Signal a premature end of the string. DZ - 2-9-1996 */`
	`240`	`+ elog(WARN, "malformed array constant: %s", str);`
	`241`	`+ break;`
`238`	`242`	`case '\"':`
`239`	`243`	`scanning_string = ! scanning_string;`
`240`	`244`	`break;`