Use proper types so it compiles on DEC C89. Thanks Erik Bertelson.

Bryan Henderson · Bryan Henderson · commit 3c4b21493d49 · 1997-01-08T08:39:10.000Z
diff --git a/src/backend/tcop/dest.c b/src/backend/tcop/dest.c
@@ -7,7 +7,7 @@
  *
  *
  * IDENTIFICATION
- *    $Header: /cvsroot/pgsql/src/backend/tcop/dest.c,v 1.3 1996/11/10 03:02:42 momjian Exp $
+ *    $Header: /cvsroot/pgsql/src/backend/tcop/dest.c,v 1.4 1997/01/08 08:36:31 bryanh Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -45,12 +45,12 @@
  *	output functions
  * ----------------
  */
-void
-donothing(List *tuple, List *attrdesc)
+static void
+donothing(HeapTuple tuple, TupleDesc attrdesc)
 {
 }
 
-void (*DestToFunction(CommandDest dest))()
+void (*DestToFunction(CommandDest dest))(HeapTuple, TupleDesc)
 {
     switch (dest) {
     case RemoteInternal:
diff --git a/src/backend/utils/adt/varlena.c b/src/backend/utils/adt/varlena.c
@@ -7,7 +7,7 @@
  *
  *
  * IDENTIFICATION
- *    $Header: /cvsroot/pgsql/src/backend/utils/adt/varlena.c,v 1.8 1996/11/08 05:59:51 momjian Exp $
+ *    $Header: /cvsroot/pgsql/src/backend/utils/adt/varlena.c,v 1.9 1997/01/08 08:38:59 bryanh Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -297,8 +297,8 @@ text_lt(struct varlena *arg1, struct varlena *arg2)
     if (arg1 == NULL || arg2 == NULL)
 	return((int32) 0);
     
-    a1p = VARDATA(arg1);
-    a2p = VARDATA(arg2);
+    a1p = (unsigned char *)VARDATA(arg1);
+    a2p = (unsigned char *)VARDATA(arg2);
     
     if ((len = arg1->vl_len) > arg2->vl_len)
 	len = arg2->vl_len;
@@ -328,8 +328,8 @@ text_le(struct varlena *arg1, struct varlena *arg2)
     if (arg1 == NULL || arg2 == NULL)
 	return((int32) 0);
     
-    a1p = VARDATA(arg1);
-    a2p = VARDATA(arg2);
+    a1p = (unsigned char *)VARDATA(arg1);
+    a2p = (unsigned char *)VARDATA(arg2);
     
     if ((len = arg1->vl_len) > arg2->vl_len)
 	len = arg2->vl_len;
diff --git a/src/include/tcop/dest.h b/src/include/tcop/dest.h
@@ -26,7 +26,7 @@
  *
  * Copyright (c) 1994, Regents of the University of California
  *
- * $Id: dest.h,v 1.4 1996/11/10 03:06:08 momjian Exp $
+ * $Id: dest.h,v 1.5 1997/01/08 08:39:10 bryanh Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -61,7 +61,6 @@ typedef struct AttrInfo {
 } AttrInfo;
 */
 
-extern void donothing(List *tuple, List *attrdesc);
 extern void (*DestToFunction(CommandDest dest))();
 extern void EndCommand(char *commandTag, CommandDest dest);
 extern void SendCopyBegin(void);

Original file line number	Diff line number	Diff line change
`@@ -7,7 +7,7 @@`
`7`	`7`	`*`
`8`	`8`	`*`
`9`	`9`	`* IDENTIFICATION`
`10`		`- * $Header: /cvsroot/pgsql/src/backend/tcop/dest.c,v 1.3 1996/11/10 03:02:42 momjian Exp $`
	`10`	`+ * $Header: /cvsroot/pgsql/src/backend/tcop/dest.c,v 1.4 1997/01/08 08:36:31 bryanh Exp $`
`11`	`11`	`*`
`12`	`12`	`*-------------------------------------------------------------------------`
`13`	`13`	`*/`
`@@ -45,12 +45,12 @@`
`45`	`45`	`* output functions`
`46`	`46`	`* ----------------`
`47`	`47`	`*/`
`48`		`-void`
`49`		`-donothing(List tuple, List attrdesc)`
	`48`	`+static void`
	`49`	`+donothing(HeapTuple tuple, TupleDesc attrdesc)`
`50`	`50`	`{`
`51`	`51`	`}`
`52`	`52`
`53`		`-void (*DestToFunction(CommandDest dest))()`
	`53`	`+void (*DestToFunction(CommandDest dest))(HeapTuple, TupleDesc)`
`54`	`54`	`{`
`55`	`55`	`switch (dest) {`
`56`	`56`	`case RemoteInternal:`
Original file line number	Diff line number	Diff line change
`@@ -26,7 +26,7 @@`
`26`	`26`	`*`
`27`	`27`	`* Copyright (c) 1994, Regents of the University of California`
`28`	`28`	`*`
`29`		`- * $Id: dest.h,v 1.4 1996/11/10 03:06:08 momjian Exp $`
	`29`	`+ * $Id: dest.h,v 1.5 1997/01/08 08:39:10 bryanh Exp $`
`30`	`30`	`*`
`31`	`31`	`*-------------------------------------------------------------------------`
`32`	`32`	`*/`
`@@ -61,7 +61,6 @@ typedef struct AttrInfo {`
`61`	`61`	`} AttrInfo;`
`62`	`62`	`*/`
`63`	`63`
`64`		`-extern void donothing(List tuple, List attrdesc);`
`65`	`64`	`extern void (*DestToFunction(CommandDest dest))();`
`66`	`65`	`extern void EndCommand(char *commandTag, CommandDest dest);`
`67`	`66`	`extern void SendCopyBegin(void);`