Restore psql's SIGPIPE setting if popen() fails.

tglsfdc · tglsfdc · commit 433e65c2bd90 · 2016-12-07T12:39:24.000-05:00
Ancient oversight in PageOutput(): if popen() fails, we'd better reset
the SIGPIPE handler before returning stdout, because ClosePager() won't.
Noticed while fixing the empty-PAGER issue.
diff --git a/src/bin/psql/print.c b/src/bin/psql/print.c
@@ -2217,6 +2217,10 @@ PageOutput(int lines, unsigned short int pager)
 			pagerpipe = popen(pagerprog, "w");
 			if (pagerpipe)
 				return pagerpipe;
+			/* if popen fails, silently proceed without pager */
+#ifndef WIN32
+			pqsignal(SIGPIPE, SIG_DFL);
+#endif
 #ifdef TIOCGWINSZ
 		}
 #endif
