Add missing support for the latest SPI status codes.

deanrasheed · deanrasheed · commit 482ab3e4f9e0 · 2023-02-22T13:26:20.000Z
SPI_result_code_string() was missing support for SPI_OK_TD_REGISTER, and in v15 and later, it was missing support for SPI_OK_MERGE, as was pltcl_process_SPI_result(). The last of those would trigger an error if a MERGE was executed from PL/Tcl. The others seem fairly innocuous, but worth fixing. Back-patch to all supported branches. Before v15, this is just adding SPI_OK_TD_REGISTER to SPI_result_code_string(), which is unlikely to be seen by anyone, but seems worth doing for completeness. Reviewed by Tom Lane. Discussion: https://postgr.es/m/CAEZATCUg8V%2BK%2BGcafOPqymxk84Y_prXgfe64PDoopjLFH6Z0Aw%40mail.gmail.com https://postgr.es/m/CAEZATCUMe%2B_KedPMM9AxKqm%3DSZogSxjUcrMe%2BsakusZh3BFcQw%40mail.gmail.com
diff --git a/src/backend/executor/spi.c b/src/backend/executor/spi.c
@@ -2039,6 +2039,8 @@ SPI_result_code_string(int code)
 			return "SPI_OK_REL_REGISTER";
 		case SPI_OK_REL_UNREGISTER:
 			return "SPI_OK_REL_UNREGISTER";
+		case SPI_OK_TD_REGISTER:
+			return "SPI_OK_TD_REGISTER";
 	}
 	/* Unrecognized code ... return something useful ... */
 	sprintf(buf, "Unrecognized SPI code %d", code);

Original file line number	Diff line number	Diff line change
`@@ -2039,6 +2039,8 @@ SPI_result_code_string(int code)`
`2039`	`2039`	`return "SPI_OK_REL_REGISTER";`
`2040`	`2040`	`case SPI_OK_REL_UNREGISTER:`
`2041`	`2041`	`return "SPI_OK_REL_UNREGISTER";`
	`2042`	`+ case SPI_OK_TD_REGISTER:`
	`2043`	`+ return "SPI_OK_TD_REGISTER";`
`2042`	`2044`	`}`
`2043`	`2045`	`/* Unrecognized code ... return something useful ... */`
`2044`	`2046`	`sprintf(buf, "Unrecognized SPI code %d", code);`