Fix the error message when failing to restore the snapshot.

Amit Kapila · pull[bot] · commit 4865bcaa8200 · 2024-04-09T05:02:06.000Z
The SnapBuildRestoreContents() used a const value in the error message to indicate the size in bytes it was expecting to read from the serialized snapshot file. Fix it by reporting the size that was actually passed. Author: Hou Zhijie Reviewed-by: Amit Kapila Backpatch-through: 16 Discussion: http://postgr.es/m/OS0PR01MB5716D408364F7DF32221C08D941FA@OS0PR01MB5716.jpnprd01.prod.outlook.com
diff --git a/src/backend/replication/logical/snapbuild.c b/src/backend/replication/logical/snapbuild.c
@@ -2039,7 +2039,7 @@ SnapBuildRestoreContents(int fd, char *dest, Size size, const char *path)
 			ereport(ERROR,
 					(errcode(ERRCODE_DATA_CORRUPTED),
 					 errmsg("could not read file \"%s\": read %d of %zu",
-							path, readBytes, sizeof(SnapBuild))));
+							path, readBytes, size)));
 	}
 }
 

Original file line number	Diff line number	Diff line change
`@@ -2039,7 +2039,7 @@ SnapBuildRestoreContents(int fd, char dest, Size size, const char path)`
`2039`	`2039`	`ereport(ERROR,`
`2040`	`2040`	`(errcode(ERRCODE_DATA_CORRUPTED),`
`2041`	`2041`	`errmsg("could not read file \"%s\": read %d of %zu",`
`2042`		`- path, readBytes, sizeof(SnapBuild))));`
	`2042`	`+ path, readBytes, size)));`
`2043`	`2043`	`}`
`2044`	`2044`	`}`
`2045`	`2045`