Fix error-checking typo in check_TSCurrentConfig().

tglsfdc · tglsfdc · commit 4a6232cce315 · 2013-01-20T23:10:18.000-05:00
The code failed to detect an out-of-memory failure.

Xi Wang
diff --git a/src/backend/utils/cache/ts_cache.c b/src/backend/utils/cache/ts_cache.c
@@ -643,7 +643,7 @@ check_TSCurrentConfig(char **newval, void **extra, GucSource source)
 		free(*newval);
 		*newval = strdup(buf);
 		pfree(buf);
-		if (!newval)
+		if (!*newval)
 			return false;
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -643,7 +643,7 @@ check_TSCurrentConfig(char newval, void extra, GucSource source)`
`643`	`643`	`free(*newval);`
`644`	`644`	`*newval = strdup(buf);`
`645`	`645`	`pfree(buf);`
`646`		`- if (!newval)`
	`646`	`+ if (!*newval)`
`647`	`647`	`return false;`
`648`	`648`	`}`
`649`	`649`