Remove wrongly backpatched piece of code in cube.c

feodor · feodor · commit 5b0fa06f65e9 · 2018-04-10T14:59:27.000+03:00
Due to sloppy division of changes between f50c80d (which was not back-patched) and 563a053, this piece of code was wrongly backpatched to REL_10_STABLE and REL9_6_STABLE. This code never causes real error because its condition is never satisfied, but it's a dead code, which needs to be removed. Alexander Korotkov per gripe from Tom Lane
diff --git a/contrib/cube/cube.c b/contrib/cube/cube.c
@@ -1587,7 +1587,6 @@ cube_coord_llur(PG_FUNCTION_ARGS)
 {
 	NDBOX	   *cube = PG_GETARG_NDBOX(0);
 	int			coord = PG_GETARG_INT32(1);
-	bool		inverse = false;
 	float8		result;
 
 	/* 0 is the only unsupported coordinate value */
@@ -1625,10 +1624,6 @@ cube_coord_llur(PG_FUNCTION_ARGS)
 		result = 0.0;
 	}
 
-	/* Inverse value if needed */
-	if (inverse)
-		result = -result;
-
 	PG_RETURN_FLOAT8(result);
 }
 

Original file line number	Diff line number	Diff line change
`@@ -1587,7 +1587,6 @@ cube_coord_llur(PG_FUNCTION_ARGS)`
`1587`	`1587`	`{`
`1588`	`1588`	`NDBOX *cube = PG_GETARG_NDBOX(0);`
`1589`	`1589`	`int coord = PG_GETARG_INT32(1);`
`1590`		`- bool inverse = false;`
`1591`	`1590`	`float8 result;`
`1592`	`1591`
`1593`	`1592`	`/* 0 is the only unsupported coordinate value */`
`@@ -1625,10 +1624,6 @@ cube_coord_llur(PG_FUNCTION_ARGS)`
`1625`	`1624`	`result = 0.0;`
`1626`	`1625`	`}`
`1627`	`1626`
`1628`		`- /* Inverse value if needed */`
`1629`		`- if (inverse)`
`1630`		`- result = -result;`
`1631`		`-`
`1632`	`1627`	`PG_RETURN_FLOAT8(result);`
`1633`	`1628`	`}`
`1634`	`1629`