In pg_upgrade cross-version test, handle lack of oldstyle_length().

nmisch · nmisch · commit 5c3444e31384 · 2020-12-30T01:43:47.000-08:00
This suffices for testing v12 -&gt; v13; some other version pairs need more
changes.  Back-patch to v10, which removed the function.
diff --git a/src/bin/pg_upgrade/test.sh b/src/bin/pg_upgrade/test.sh
@@ -184,17 +184,17 @@ createdb "$dbname3" || createdb_status=$?
 if "$MAKE" -C "$oldsrc" installcheck; then
 	oldpgversion=`psql -X -A -t -d regression -c "SHOW server_version_num"`
 
-	# before dumping, get rid of objects not existing in later versions
+	# before dumping, get rid of objects not feasible in later versions
 	if [ "$newsrc" != "$oldsrc" ]; then
 		fix_sql=""
 		case $oldpgversion in
 			804??)
-				fix_sql="DROP FUNCTION public.myfunc(integer); DROP FUNCTION public.oldstyle_length(integer, text);"
-				;;
-			*)
-				fix_sql="DROP FUNCTION public.oldstyle_length(integer, text);"
+				fix_sql="DROP FUNCTION public.myfunc(integer);"
 				;;
 		esac
+		fix_sql="$fix_sql
+				 DROP FUNCTION IF EXISTS
+					public.oldstyle_length(integer, text);	-- last in 9.6";
 		psql -X -d regression -c "$fix_sql;" || psql_fix_sql_status=$?
 	fi
 
