Fix ginint4_queryextract() to actually do what it was intended to do for an

tglsfdc · tglsfdc · commit 5ceb13c8a123 · 2010-03-25T15:50:10.000Z
unsatisfiable query, such as indexcol &amp;&amp; empty_array.  It should return -1
to tell GIN no scan is required; but silly typo disabled the logic for that,
resulting in unnecessary "GIN indexes do not support whole-index scans" error.
Per bug report from Jeff Trout.

Back-patch to 8.3 where the logic was introduced.
diff --git a/contrib/intarray/_int_gin.c b/contrib/intarray/_int_gin.c
@@ -1,5 +1,5 @@
 /*
- * $PostgreSQL: pgsql/contrib/intarray/_int_gin.c,v 1.10 2009/06/11 14:48:51 momjian Exp $
+ * $PostgreSQL: pgsql/contrib/intarray/_int_gin.c,v 1.11 2010/03/25 15:50:10 tgl Exp $
  */
 #include "postgres.h"
 
@@ -65,7 +65,7 @@ ginint4_queryextract(PG_FUNCTION_ARGS)
 		}
 	}
 
-	if (nentries == 0)
+	if (*nentries == 0)
 	{
 		switch (strategy)
 		{

Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,5 @@`
`1`	`1`	`/*`
`2`		`- * $PostgreSQL: pgsql/contrib/intarray/_int_gin.c,v 1.10 2009/06/11 14:48:51 momjian Exp $`
	`2`	`+ * $PostgreSQL: pgsql/contrib/intarray/_int_gin.c,v 1.11 2010/03/25 15:50:10 tgl Exp $`
`3`	`3`	`*/`
`4`	`4`	`#include "postgres.h"`
`5`	`5`
`@@ -65,7 +65,7 @@ ginint4_queryextract(PG_FUNCTION_ARGS)`
`65`	`65`	`}`
`66`	`66`	`}`
`67`	`67`
`68`		`- if (nentries == 0)`
	`68`	`+ if (*nentries == 0)`
`69`	`69`	`{`
`70`	`70`	`switch (strategy)`
`71`	`71`	`{`