Add temporary debugging assertion, in 9.4 branch only.

tglsfdc · tglsfdc · commit 5ee940e1cdb6 · 2018-04-15T20:23:59.000-04:00
Buildfarm member okapi has been failing the multiple-cic isolation
test for months now, but only in 9.4.  To narrow down the possible
causes, add an Assert testing that CREATE INDEX CONCURRENTLY is
advertising zero xmin before waiting for other transactions to end.

I'm not sure that this would hold in general, so this assertion isn't
meant to get released, but it passes all 9.4 regression tests for me.
Will revert once we see how okapi responds.
diff --git a/src/backend/commands/indexcmds.c b/src/backend/commands/indexcmds.c
@@ -773,6 +773,9 @@ DefineIndex(Oid relationId,
 	UnregisterSnapshot(snapshot);
 	InvalidateCatalogSnapshot();
 
+	/* Temporary debug check: we should be advertising we have no snapshots. */
+	Assert(MyPgXact->xmin == InvalidTransactionId);
+
 	/*
 	 * The index is now valid in the sense that it contains all currently
 	 * interesting tuples.  But since it might not contain tuples deleted just
