Small code simplifications

petere · petere · commit 6114040711af · 2020-12-03T11:44:13.000+01:00
strVal() can be used in a couple of places instead of coding the same
thing by hand.
diff --git a/src/backend/foreign/foreign.c b/src/backend/foreign/foreign.c
@@ -544,7 +544,7 @@ deflist_to_tuplestore(ReturnSetInfo *rsinfo, List *options)
 		nulls[0] = false;
 		if (def->arg)
 		{
-			values[1] = CStringGetTextDatum(((Value *) (def->arg))->val.str);
+			values[1] = CStringGetTextDatum(strVal(def->arg));
 			nulls[1] = false;
 		}
 		else
diff --git a/src/backend/parser/gram.y b/src/backend/parser/gram.y
@@ -13890,7 +13890,7 @@ func_expr_common_subexpr:
 					 * Convert SystemTypeName() to SystemFuncName() even though
 					 * at the moment they result in the same thing.
 					 */
-					$$ = (Node *) makeFuncCall(SystemFuncName(((Value *) llast($5->names))->val.str),
+					$$ = (Node *) makeFuncCall(SystemFuncName(strVal(llast($5->names))),
 											   list_make1($3),
 											   COERCE_EXPLICIT_CALL,
 											   @1);

Original file line number	Diff line number	Diff line change
`@@ -544,7 +544,7 @@ deflist_to_tuplestore(ReturnSetInfo rsinfo, List options)`
`544`	`544`	`nulls[0] = false;`
`545`	`545`	`if (def->arg)`
`546`	`546`	`{`
`547`		`- values[1] = CStringGetTextDatum(((Value *) (def->arg))->val.str);`
	`547`	`+ values[1] = CStringGetTextDatum(strVal(def->arg));`
`548`	`548`	`nulls[1] = false;`
`549`	`549`	`}`
`550`	`550`	`else`