Undo a couple of mistaken applications of NameStr() to StringInfos.

tglsfdc · tglsfdc · commit 664908f5643f · 2000-02-26T06:36:44.000Z
It worked, because they both have fields named 'data', but it's surely
trouble waiting to happen.  I wonder whether there are more ...
diff --git a/src/backend/rewrite/rewriteDefine.c b/src/backend/rewrite/rewriteDefine.c
@@ -8,7 +8,7 @@
  *
  *
  * IDENTIFICATION
- *	  $Header: /cvsroot/pgsql/src/backend/rewrite/rewriteDefine.c,v 1.42 2000/01/27 18:11:36 tgl Exp $
+ *	  $Header: /cvsroot/pgsql/src/backend/rewrite/rewriteDefine.c,v 1.43 2000/02/26 06:36:44 tgl Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -119,9 +119,9 @@ InsertRule(char *rulname,
 	appendStringInfo(&rulebuf, "::text, '%s'::bool);",
 					 is_instead);
 
-	pg_exec_query_dest(NameStr(rulebuf), None, true);
+	pg_exec_query_dest(rulebuf.data, None, true);
 
-	pfree(NameStr(rulebuf));
+	pfree(rulebuf.data);
 
 	return LastOidProcessed;
 }

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@`
`8`	`8`	`*`
`9`	`9`	`*`
`10`	`10`	`* IDENTIFICATION`
`11`		`- * $Header: /cvsroot/pgsql/src/backend/rewrite/rewriteDefine.c,v 1.42 2000/01/27 18:11:36 tgl Exp $`
	`11`	`+ * $Header: /cvsroot/pgsql/src/backend/rewrite/rewriteDefine.c,v 1.43 2000/02/26 06:36:44 tgl Exp $`
`12`	`12`	`*`
`13`	`13`	`*-------------------------------------------------------------------------`
`14`	`14`	`*/`
`@@ -119,9 +119,9 @@ InsertRule(char *rulname,`
`119`	`119`	`appendStringInfo(&rulebuf, "::text, '%s'::bool);",`
`120`	`120`	`is_instead);`
`121`	`121`
`122`		`- pg_exec_query_dest(NameStr(rulebuf), None, true);`
	`122`	`+ pg_exec_query_dest(rulebuf.data, None, true);`
`123`	`123`
`124`		`- pfree(NameStr(rulebuf));`
	`124`	`+ pfree(rulebuf.data);`
`125`	`125`
`126`	`126`	`return LastOidProcessed;`
`127`	`127`	`}`