Fix ancient compiler warnings and typos in !HAVE_SYMLINK code

petere · petere · commit 669d9eae8531 · 2018-12-22T07:25:43.000+01:00
This has never been correct since this code was introduced.
diff --git a/src/bin/initdb/initdb.c b/src/bin/initdb/initdb.c
@@ -2813,7 +2813,7 @@ create_xlog_or_symlink(void)
 			exit_nicely();
 		}
 #else
-		fprintf(stderr, _("%s: symlinks are not supported on this platform"));
+		fprintf(stderr, _("%s: symlinks are not supported on this platform\n"), progname);
 		exit_nicely();
 #endif
 	}
diff --git a/src/bin/pg_basebackup/pg_basebackup.c b/src/bin/pg_basebackup/pg_basebackup.c
@@ -2430,7 +2430,7 @@ main(int argc, char **argv)
 			disconnect_and_exit(1);
 		}
 #else
-		fprintf(stderr, _("%s: symlinks are not supported on this platform\n"));
+		fprintf(stderr, _("%s: symlinks are not supported on this platform\n"), progname);
 		disconnect_and_exit(1);
 #endif
 		free(linkloc);

Original file line number	Diff line number	Diff line change
`@@ -2813,7 +2813,7 @@ create_xlog_or_symlink(void)`
`2813`	`2813`	`exit_nicely();`
`2814`	`2814`	`}`
`2815`	`2815`	`#else`
`2816`		`- fprintf(stderr, _("%s: symlinks are not supported on this platform"));`
	`2816`	`+ fprintf(stderr, _("%s: symlinks are not supported on this platform\n"), progname);`
`2817`	`2817`	`exit_nicely();`
`2818`	`2818`	`#endif`
`2819`	`2819`	`}`
Original file line number	Diff line number	Diff line change
`@@ -2430,7 +2430,7 @@ main(int argc, char **argv)`
`2430`	`2430`	`disconnect_and_exit(1);`
`2431`	`2431`	`}`
`2432`	`2432`	`#else`
`2433`		`- fprintf(stderr, _("%s: symlinks are not supported on this platform\n"));`
	`2433`	`+ fprintf(stderr, _("%s: symlinks are not supported on this platform\n"), progname);`
`2434`	`2434`	`disconnect_and_exit(1);`
`2435`	`2435`	`#endif`
`2436`	`2436`	`free(linkloc);`