Fix typo in PQconnectStartParams().

tglsfdc · tglsfdc · commit 672def622593 · 2011-04-02T18:05:46.000-04:00
This would lead to leaking the PGconn structure after an error detected by
conninfo_array_parse(), as well as failing to return a useful error message
in such cases.  Backpatch to 9.0 where the error was introduced.

Joseph Adams
diff --git a/src/interfaces/libpq/fe-connect.c b/src/interfaces/libpq/fe-connect.c
@@ -446,7 +446,7 @@ PQconnectStartParams(const char **keywords,
 	{
 		conn->status = CONNECTION_BAD;
 		/* errorMessage is already set */
-		return false;
+		return conn;
 	}
 
 	/*

Original file line number	Diff line number	Diff line change
`@@ -446,7 +446,7 @@ PQconnectStartParams(const char **keywords,`
`446`	`446`	`{`
`447`	`447`	`conn->status = CONNECTION_BAD;`
`448`	`448`	`/* errorMessage is already set */`
`449`		`- return false;`
	`449`	`+ return conn;`
`450`	`450`	`}`
`451`	`451`
`452`	`452`	`/*`