Make pg_dump acquire lock on partitioned tables that are to be dumped.

tglsfdc · tglsfdc · commit 6a262ba8c864 · 2021-10-16T12:24:17.000-04:00
It was clearly the intent to do so all along, but the original coding fat-fingered this by checking the wrong array element. We fixed it in passing in 403a3d9, but that later got reverted, and we forgot to keep this bug fix. Most of the time this'd be relatively harmless, since once we lock any of the partitioned table's leaf partitions, that would suffice to prevent major DDL on the partitioned table itself. However, a childless partitioned table would get dumped with no relevant lock whatsoever, possibly allowing dump failure or inconsistent output. Unlike 403a3d9, there are no versioning concerns, since every server version that has partitioned tables will allow you to lock one. Back-patch to v10 where partitioned tables were introduced. Discussion: https://postgr.es/m/1018205.1634346327@sss.pgh.pa.us
diff --git a/src/bin/pg_dump/pg_dump.c b/src/bin/pg_dump/pg_dump.c
@@ -6847,7 +6847,7 @@ getTables(Archive *fout, int *numTables)
 		 */
 		if (tblinfo[i].dobj.dump &&
 			(tblinfo[i].relkind == RELKIND_RELATION ||
-			 tblinfo->relkind == RELKIND_PARTITIONED_TABLE) &&
+			 tblinfo[i].relkind == RELKIND_PARTITIONED_TABLE) &&
 			(tblinfo[i].dobj.dump & DUMP_COMPONENTS_REQUIRING_LOCK))
 		{
 			resetPQExpBuffer(query);

Original file line number	Diff line number	Diff line change
`@@ -6847,7 +6847,7 @@ getTables(Archive fout, int numTables)`
`6847`	`6847`	`*/`
`6848`	`6848`	`if (tblinfo[i].dobj.dump &&`
`6849`	`6849`	`(tblinfo[i].relkind == RELKIND_RELATION \|\|`
`6850`		`- tblinfo->relkind == RELKIND_PARTITIONED_TABLE) &&`
	`6850`	`+ tblinfo[i].relkind == RELKIND_PARTITIONED_TABLE) &&`
`6851`	`6851`	`(tblinfo[i].dobj.dump & DUMP_COMPONENTS_REQUIRING_LOCK))`
`6852`	`6852`	`{`
`6853`	`6853`	`resetPQExpBuffer(query);`