Use a slightly more liberal regex to detect Visual Studio version

adunstan · adunstan · commit 6b02bee66cae · 2020-04-17T14:52:42.000-04:00
Apparently in some language versions of Visual Studio nmake outputs some
material after the version number and before the end of the line. This
has been seen in Chinese versions. Therefore, we no longer demand that
the version string comes at the end of a line.

Per complaint from Cuiping Lin.

Backpatch to all live branches.
diff --git a/src/tools/msvc/VSObjectFactory.pm b/src/tools/msvc/VSObjectFactory.pm
@@ -119,7 +119,7 @@ sub DetermineVisualStudioVersion
 	$? >> 8 == 0
 	  or croak
 	  "Unable to determine Visual Studio version: The nmake command wasn't found.";
-	if ($output =~ /(\d+)\.(\d+)\.\d+(\.\d+)?$/m)
+	if ($output =~ /(\d+)\.(\d+)\.\d+(\.\d+)?/)
 	{
 		return _GetVisualStudioVersion($1, $2);
 	}

Original file line number	Diff line number	Diff line change
`@@ -119,7 +119,7 @@ sub DetermineVisualStudioVersion`
`119`	`119`	`$? >> 8 == 0`
`120`	`120`	`or croak`
`121`	`121`	`"Unable to determine Visual Studio version: The nmake command wasn't found.";`
`122`		`- if ($output =~ /(\d+)\.(\d+)\.\d+(\.\d+)?$/m)`
	`122`	`+ if ($output =~ /(\d+)\.(\d+)\.\d+(\.\d+)?/)`
`123`	`123`	`{`
`124`	`124`	`return _GetVisualStudioVersion($1, $2);`
`125`	`125`	`}`