Silence compiler warnings

jconway · jconway · commit 6b4a1764aa5d · 2017-01-02T14:12:28.000-08:00
In GetCachedPlan(), initialize 'plan' to silence a compiler warning, but also add an Assert() to make sure we don't ever actually fall through with 'plan' still being set to NULL, since we are about to dereference it. Back-patch back to 9.2. Author: Stephen Frost Discussion: https://postgr.es/m/20161129152102.GR13284%40tamriel.snowman.net
diff --git a/src/backend/utils/cache/plancache.c b/src/backend/utils/cache/plancache.c
@@ -1093,7 +1093,7 @@ CachedPlan *
 GetCachedPlan(CachedPlanSource *plansource, ParamListInfo boundParams,
 			  bool useResOwner)
 {
-	CachedPlan *plan;
+	CachedPlan *plan = NULL;
 	List	   *qlist;
 	bool		customplan;
 
@@ -1175,6 +1175,8 @@ GetCachedPlan(CachedPlanSource *plansource, ParamListInfo boundParams,
 		}
 	}
 
+	Assert(plan != NULL);
+
 	/* Flag the plan as in use by caller */
 	if (useResOwner)
 		ResourceOwnerEnlargePlanCacheRefs(CurrentResourceOwner);

Original file line number	Diff line number	Diff line change
`@@ -1093,7 +1093,7 @@ CachedPlan *`
`1093`	`1093`	`GetCachedPlan(CachedPlanSource *plansource, ParamListInfo boundParams,`
`1094`	`1094`	`bool useResOwner)`
`1095`	`1095`	`{`
`1096`		`- CachedPlan *plan;`
	`1096`	`+ CachedPlan *plan = NULL;`
`1097`	`1097`	`List *qlist;`
`1098`	`1098`	`bool customplan;`
`1099`	`1099`
`@@ -1175,6 +1175,8 @@ GetCachedPlan(CachedPlanSource *plansource, ParamListInfo boundParams,`
`1175`	`1175`	`}`
`1176`	`1176`	`}`
`1177`	`1177`
	`1178`	`+ Assert(plan != NULL);`
	`1179`	`+`
`1178`	`1180`	`/* Flag the plan as in use by caller */`
`1179`	`1181`	`if (useResOwner)`
`1180`	`1182`	`ResourceOwnerEnlargePlanCacheRefs(CurrentResourceOwner);`