Fix under-parenthesized macro definitions

alvherre · alvherre · commit 6d50fd469a46 · 2019-09-13T16:26:55.000-03:00
Lack of parens in the definitions could cause a statement using these macros to have unexpected semantics. In current code no bug is apparent, but best to fix the definitions to avoid problems down the line. Reported-by: Tom Lane Discussion: https://postgr.es/m/19795.1568400476@sss.pgh.pa.us
diff --git a/src/include/nodes/parsenodes.h b/src/include/nodes/parsenodes.h
@@ -3215,7 +3215,7 @@ typedef struct ConstraintsSetStmt
  */
 
 /* Reindex options */
-#define REINDEXOPT_VERBOSE 1 << 0	/* print progress info */
+#define REINDEXOPT_VERBOSE (1 << 0)	/* print progress info */
 
 typedef enum ReindexObjectType
 {

Original file line number	Diff line number	Diff line change
`@@ -3215,7 +3215,7 @@ typedef struct ConstraintsSetStmt`
`3215`	`3215`	`*/`
`3216`	`3216`
`3217`	`3217`	`/* Reindex options */`
`3218`		`-#define REINDEXOPT_VERBOSE 1 << 0 /* print progress info */`
	`3218`	`+#define REINDEXOPT_VERBOSE (1 << 0) /* print progress info */`
`3219`	`3219`
`3220`	`3220`	`typedef enum ReindexObjectType`
`3221`	`3221`	`{`