[ Have readline save edit history.]

bmomjian · bmomjian · commit 6d8b8a5e4ddf · 2003-02-13T04:08:16.000Z
&gt;
&gt; &gt; I already posted a one-line patch to implement this, but it doesn't
&gt; &gt; seem to hve come through to the list. Here it is inline, instead of as
&gt; &gt; an attachment:
&gt;
&gt; We need this to work without readline as well.  (Of course there won't be
&gt; any history, but it needs to compile.)

&lt;blush&gt; Even after slogging my way through the nesting #ifdefs for readline
and win32, I forgot! Let's make that a three line patch, then.

Ross J. Reedstrom
diff --git a/src/bin/psql/command.c b/src/bin/psql/command.c
@@ -3,7 +3,7 @@
  *
  * Copyright 2000-2002 by PostgreSQL Global Development Group
  *
- * $Header: /cvsroot/pgsql/src/bin/psql/command.c,v 1.88 2003/01/10 21:57:44 petere Exp $
+ * $Header: /cvsroot/pgsql/src/bin/psql/command.c,v 1.89 2003/02/13 04:08:16 momjian Exp $
  */
 #include "postgres_fe.h"
 #include "command.h"
@@ -1648,6 +1648,9 @@ do_edit(const char *filename_arg, PQExpBuffer query_buf)
 				error = true;
 			}
 
+#ifdef USE_READLINE
+			replace_history_entry(where_history(),query_buf->data,NULL);
+#endif
 			fclose(stream);
 		}
 

Original file line number	Diff line number	Diff line change
`@@ -3,7 +3,7 @@`
`3`	`3`	`*`
`4`	`4`	`* Copyright 2000-2002 by PostgreSQL Global Development Group`
`5`	`5`	`*`
`6`		`- * $Header: /cvsroot/pgsql/src/bin/psql/command.c,v 1.88 2003/01/10 21:57:44 petere Exp $`
	`6`	`+ * $Header: /cvsroot/pgsql/src/bin/psql/command.c,v 1.89 2003/02/13 04:08:16 momjian Exp $`
`7`	`7`	`*/`
`8`	`8`	`#include "postgres_fe.h"`
`9`	`9`	`#include "command.h"`
`@@ -1648,6 +1648,9 @@ do_edit(const char *filename_arg, PQExpBuffer query_buf)`
`1648`	`1648`	`error = true;`
`1649`	`1649`	`}`
`1650`	`1650`
	`1651`	`+#ifdef USE_READLINE`
	`1652`	`+ replace_history_entry(where_history(),query_buf->data,NULL);`
	`1653`	`+#endif`
`1651`	`1654`	`fclose(stream);`
`1652`	`1655`	`}`
`1653`	`1656`