Fix pg_dump's sigTermHandler() to use _exit() not exit().

tglsfdc · tglsfdc · commit 6f6daa1be785 · 2020-01-20T12:57:17.000-05:00
sigTermHandler() tried to be careful to invoke only operations that are safe to do in a signal handler. But for some reason we forgot that exit(3) is not among those, because it calls atexit handlers that might do various random things. (pg_dump itself installs no atexit handlers, but e.g. OpenSSL does.) That led to crashes or lockups when attempting to terminate a parallel dump or restore via a signal. Fix by calling _exit() instead. Per bug #16199 from Raúl Marín. Back-patch to all supported branches. Discussion: https://postgr.es/m/16199-cb2f121146a96f9b@postgresql.org
diff --git a/src/bin/pg_dump/parallel.c b/src/bin/pg_dump/parallel.c
@@ -609,8 +609,11 @@ sigTermHandler(SIGNAL_ARGS)
 		write_stderr("terminated by user\n");
 	}
 
-	/* And die. */
-	exit(1);
+	/*
+	 * And die, using _exit() not exit() because the latter will invoke atexit
+	 * handlers that can fail if we interrupted related code.
+	 */
+	_exit(1);
 }
 
 /*

Original file line number	Diff line number	Diff line change
`@@ -609,8 +609,11 @@ sigTermHandler(SIGNAL_ARGS)`
`609`	`609`	`write_stderr("terminated by user\n");`
`610`	`610`	`}`
`611`	`611`
`612`		`- /* And die. */`
`613`		`- exit(1);`
	`612`	`+ /*`
	`613`	`+ * And die, using _exit() not exit() because the latter will invoke atexit`
	`614`	`+ * handlers that can fail if we interrupted related code.`
	`615`	`+ */`
	`616`	`+ _exit(1);`
`614`	`617`	`}`
`615`	`618`
`616`	`619`	`/*`