Fix missing PQclear() in libpqrcv_endstreaming().

tglsfdc · tglsfdc · commit 734bbf2e9783 · 2015-02-11T19:20:49.000-05:00
This omission leaked one PGresult per WAL streaming cycle, which possibly
would never be enough to notice in the real world, but it's still a leak.

Per Coverity.  Back-patch to 9.3 where the error was introduced.
diff --git a/src/backend/replication/libpqwalreceiver/libpqwalreceiver.c b/src/backend/replication/libpqwalreceiver/libpqwalreceiver.c
@@ -246,6 +246,7 @@ libpqrcv_endstreaming(TimeLineID *next_tli)
 		ereport(ERROR,
 				(errmsg("error reading result of streaming command: %s",
 						PQerrorMessage(streamConn))));
+	PQclear(res);
 
 	/* Verify that there are no more results */
 	res = PQgetResult(streamConn);
