Use repalloc_huge() to enlarge a SPITupleTable's tuple pointer array.

tglsfdc · tglsfdc · commit 74a379b984d4 · 2016-03-14T14:22:34.000-04:00
Commit 23a27b0 widened the rows-stored counters to uint64, but that's academic unless we allow the tuple pointer array to exceed 1GB. (It might be a good idea to provide some other limit on how much storage a SPITupleTable can eat. On the other hand, there are plenty of other ways to drive a backend into swap hell.) Dagfinn Ilmari Mannsåker
diff --git a/src/backend/executor/spi.c b/src/backend/executor/spi.c
@@ -1800,7 +1800,7 @@ spi_printtup(TupleTableSlot *slot, DestReceiver *self)
 		/* Double the size of the pointer array */
 		tuptable->free = tuptable->alloced;
 		tuptable->alloced += tuptable->free;
-		tuptable->vals = (HeapTuple *) repalloc(tuptable->vals,
+		tuptable->vals = (HeapTuple *) repalloc_huge(tuptable->vals,
 									  tuptable->alloced * sizeof(HeapTuple));
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -1800,7 +1800,7 @@ spi_printtup(TupleTableSlot slot, DestReceiver self)`
`1800`	`1800`	`/* Double the size of the pointer array */`
`1801`	`1801`	`tuptable->free = tuptable->alloced;`
`1802`	`1802`	`tuptable->alloced += tuptable->free;`
`1803`		`- tuptable->vals = (HeapTuple *) repalloc(tuptable->vals,`
	`1803`	`+ tuptable->vals = (HeapTuple *) repalloc_huge(tuptable->vals,`
`1804`	`1804`	`tuptable->alloced * sizeof(HeapTuple));`
`1805`	`1805`	`}`
`1806`	`1806`