Fix to_date()/to_timestamp() 'D' field for day of week, was off by one.

bmomjian · bmomjian · commit 764122471a85 · 2007-02-14T05:10:55.000Z
Converting from char using 'D' doesn't make lots of sense, of course.

Report from Brendan Jurd.
diff --git a/src/backend/utils/adt/formatting.c b/src/backend/utils/adt/formatting.c
@@ -1,7 +1,7 @@
 /* -----------------------------------------------------------------------
  * formatting.c
  *
- * $PostgreSQL: pgsql/src/backend/utils/adt/formatting.c,v 1.123 2007/02/13 02:00:55 momjian Exp $
+ * $PostgreSQL: pgsql/src/backend/utils/adt/formatting.c,v 1.124 2007/02/14 05:10:55 momjian Exp $
  *
  *
  *	 Portions Copyright (c) 1999-2007, PostgreSQL Global Development Group
@@ -2484,6 +2484,7 @@ dch_date(int arg, char *inout, int suf, bool is_to_char, bool is_interval,
 			else
 			{
 				sscanf(inout, "%1d", &tmfc->d);
+				tmfc->d--;
 				return strspace_len(inout) + 1 + SKIP_THth(suf);
 			}
 			break;

Original file line number	Diff line number	Diff line change
`@@ -1,7 +1,7 @@`
`1`	`1`	`/* -----------------------------------------------------------------------`
`2`	`2`	`* formatting.c`
`3`	`3`	`*`
`4`		`- * $PostgreSQL: pgsql/src/backend/utils/adt/formatting.c,v 1.123 2007/02/13 02:00:55 momjian Exp $`
	`4`	`+ * $PostgreSQL: pgsql/src/backend/utils/adt/formatting.c,v 1.124 2007/02/14 05:10:55 momjian Exp $`
`5`	`5`	`*`
`6`	`6`	`*`
`7`	`7`	`* Portions Copyright (c) 1999-2007, PostgreSQL Global Development Group`
`@@ -2484,6 +2484,7 @@ dch_date(int arg, char *inout, int suf, bool is_to_char, bool is_interval,`
`2484`	`2484`	`else`
`2485`	`2485`	`{`
`2486`	`2486`	`sscanf(inout, "%1d", &tmfc->d);`
	`2487`	`+ tmfc->d--;`
`2487`	`2488`	`return strspace_len(inout) + 1 + SKIP_THth(suf);`
`2488`	`2489`	`}`
`2489`	`2490`	`break;`