Change PyInit_plpy to external linkage

petere · petere · commit 7b1509d56256 · 2011-08-18T13:41:56.000+03:00
Module initialization functions in Python 3 must have external
linkage, because PyMODINIT_FUNC does dllexport on Windows-like
platforms.  Without this change, the build with Python 3 fails on
Windows.
diff --git a/src/pl/plpython/plpython.c b/src/pl/plpython/plpython.c
@@ -4026,7 +4026,13 @@ PLy_add_exceptions(PyObject *plpy)
 }
 
 #if PY_MAJOR_VERSION >= 3
-static PyMODINIT_FUNC
+/*
+ * Must have external linkage, because PyMODINIT_FUNC does dllexport on
+ * Windows-like platforms.
+ */
+PyMODINIT_FUNC PyInit_plpy(void);
+
+PyMODINIT_FUNC
 PyInit_plpy(void)
 {
 	PyObject   *m;

Original file line number	Diff line number	Diff line change
`@@ -4026,7 +4026,13 @@ PLy_add_exceptions(PyObject *plpy)`
`4026`	`4026`	`}`
`4027`	`4027`
`4028`	`4028`	`#if PY_MAJOR_VERSION >= 3`
`4029`		`-static PyMODINIT_FUNC`
	`4029`	`+/*`
	`4030`	`+ * Must have external linkage, because PyMODINIT_FUNC does dllexport on`
	`4031`	`+ * Windows-like platforms.`
	`4032`	`+ */`
	`4033`	`+PyMODINIT_FUNC PyInit_plpy(void);`
	`4034`	`+`
	`4035`	`+PyMODINIT_FUNC`
`4030`	`4036`	`PyInit_plpy(void)`
`4031`	`4037`	`{`
`4032`	`4038`	`PyObject *m;`