Fixed growing of backend due to not pfree()'d data on COPY FROM

Jan Wieck · Jan Wieck · commit 7fc75517df6b · 1999-02-01T20:25:55.000Z
Fixed growing of backend if BEFORE DELETE trigger returns heap tuple
different from trigtuple.

Jan
diff --git a/src/backend/commands/copy.c b/src/backend/commands/copy.c
@@ -6,7 +6,7 @@
  *
  *
  * IDENTIFICATION
- *	  $Header: /cvsroot/pgsql/src/backend/commands/copy.c,v 1.68 1999/01/23 22:27:26 tgl Exp $
+ *	  $Header: /cvsroot/pgsql/src/backend/commands/copy.c,v 1.69 1999/02/01 20:25:54 wieck Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -651,7 +651,6 @@ CopyFrom(Relation rel, bool binary, bool oids, FILE *fp, char *delim)
 	lineno = 0;
 	while (!done)
 	{
-	  values = (Datum *) palloc(sizeof(Datum) * attr_count);
 		if (!binary)
 		{
 #ifdef COPY_PATCH
diff --git a/src/backend/commands/trigger.c b/src/backend/commands/trigger.c
@@ -684,6 +684,8 @@ ExecBRDeleteTriggers(EState *estate, ItemPointer tupleid)
 		newtuple = ExecCallTriggerFunc(trigger[i]);
 		if (newtuple == NULL)
 			break;
+		if (newtuple != trigtuple)
+			pfree(newtuple);
 	}
 	CurrentTriggerData = NULL;
 	pfree(SaveTriggerData);

Original file line number	Diff line number	Diff line change
`@@ -6,7 +6,7 @@`
`6`	`6`	`*`
`7`	`7`	`*`
`8`	`8`	`* IDENTIFICATION`
`9`		`- * $Header: /cvsroot/pgsql/src/backend/commands/copy.c,v 1.68 1999/01/23 22:27:26 tgl Exp $`
	`9`	`+ * $Header: /cvsroot/pgsql/src/backend/commands/copy.c,v 1.69 1999/02/01 20:25:54 wieck Exp $`
`10`	`10`	`*`
`11`	`11`	`*-------------------------------------------------------------------------`
`12`	`12`	`*/`
`@@ -651,7 +651,6 @@ CopyFrom(Relation rel, bool binary, bool oids, FILE fp, char delim)`
`651`	`651`	`lineno = 0;`
`652`	`652`	`while (!done)`
`653`	`653`	`{`
`654`		`- values = (Datum ) palloc(sizeof(Datum) attr_count);`
`655`	`654`	`if (!binary)`
`656`	`655`	`{`
`657`	`656`	`#ifdef COPY_PATCH`
Original file line number	Diff line number	Diff line change
`@@ -684,6 +684,8 @@ ExecBRDeleteTriggers(EState *estate, ItemPointer tupleid)`
`684`	`684`	`newtuple = ExecCallTriggerFunc(trigger[i]);`
`685`	`685`	`if (newtuple == NULL)`
`686`	`686`	`break;`
	`687`	`+ if (newtuple != trigtuple)`
	`688`	`+ pfree(newtuple);`
`687`	`689`	`}`
`688`	`690`	`CurrentTriggerData = NULL;`
`689`	`691`	`pfree(SaveTriggerData);`